Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Nicolas Pitre <nicolas.pitre@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers
Date	Mon, 13 Mar 2017 21:50:02 +0100
Message-ID	<tkF4K-5ZL-21@gated-at.bofh.it> (permalink)
References	<tkBua-3kO-23@gated-at.bofh.it> <tkEBH-5Mm-13@gated-at.bofh.it> <tkELn-5QZ-7@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ZlWg8+sQzqD7+ozusofdHk4DqxBiDC69P9JoHdoRbh8=; b=axLGt9+6Odkhoe8merzDdCQIZZB42bPK9g5/efMnCZ1Nd0V9j/G7eDOdk6PoyKVaz7 F+L00Iqx12A7GARlqJP5qcEIG7Sf/yoho03JydFAnZ7QtEJpTGLOpQCDRw+cbIa2J9jf u424dPKZP0XrAiEg+sXXQ5iivdUNK1vkdaoL8=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ZlWg8+sQzqD7+ozusofdHk4DqxBiDC69P9JoHdoRbh8=; b=t1ztPUILElTV/V9p5JiQvZDs4w2DxZ1kNacLGgKVnQNLomXPvGSzMCv/Q0FX9a7PLX 5fuuOGCVha7LiThgoUYu5QBUgabcpj+fC83bmXsHQwnNIht3DRZJA5uM6g2Se2oVFkQS Ue1mcHNBgQqR0NVmYc4HHgw9h7GeCQAHPIqkU9qqlgPh0eH+Jlp/ok3sHS7o04BMQxHK 7gYJ09H/poaeAPf+ipktNzg5ioUJOP724pvybeCNuhAVIN0Tm6xCGd7SLqgJXG358JyF Cxk3UTdac0ouHaaqQWdzwW5CyCbdbWlYhZaVGuXUCZGif7Q1cHED3ZPU3T7sud1/gi9U CHkw==
X-Gm-Message-State	AFeK/H07yG0D0HhI+v/yaefTFyG/epCL1jw6PiP/WxxxkznmwwZu9OewihjNn4XfqT4bSD0U
X-Received	by 10.36.137.68 with SMTP id s65mr11036843itd.70.1489437701002; Mon, 13 Mar 2017 13:41:41 -0700 (PDT)
User-Agent	Alpine 2.20 (LFD 67 2015-01-07)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	55
Organization	linux.* mail to news gateway
X-Original-Cc	"David S. Miller" <davem@davemloft.net>, stable@vger.kernel.org, Grygorii Strashko <grygorii.strashko@ti.com>, Thomas Gleixner <tglx@linutronix.de>, John Stultz <john.stultz@linaro.org>, Networking <netdev@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 13 Mar 2017 16:41:39 -0400 (EDT)
X-Original-Message-ID	<alpine.LFD.2.20.1703131629570.14436@knanqh.ubzr>
X-Original-References	<20170313165849.1378558-1-arnd@arndb.de> <alpine.LFD.2.20.1703131608100.14436@knanqh.ubzr> <CAK8P3a125rioB5Cnoa7nR9Dz_pU5=x7=06_DvXEE-dTpOBiitQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1599794

Show key headers only | View raw

On Mon, 13 Mar 2017, Arnd Bergmann wrote:

> On Mon, Mar 13, 2017 at 9:09 PM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> > On Mon, 13 Mar 2017, Arnd Bergmann wrote:
> >
> >> With posix timers having become optional, we get a build error with
> >> the cpts time sync option of the CPSW driver:
> >>
> >> drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts':
> >> drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of function 'ptp_classify_raw';did you mean 'ptp_classifier_init'? [-Werror=implicit-function-declaration]
> >>
> >> It really makes no sense to build this driver if we can't use PTP,
> >> so it's better to go back to 'select PTP_1588_CLOCK' but instead
> >> add a dependency on POSIX_TIMERS. Adding 'depends on PTP_1588_CLOCK'
> >> might also work, but has the risk of circular dependencies when
> >> mixed with other drivers using 'imply'.
> >
> > Could you elaborate on that risk please?
> 
> I have seen many circular dependencies in the past that tend to be of type
> 
> config FOO
>      depends on A
>      select B
> 
> config BAR
>      select A
>      depends on B

This is really a problem?  I mean in this example there is nothing that 
prevents A or B to be enabled independently.  Of course if you had:

config A
	depends on B

config B
	depends on A

then the circular dependency is obvious.

> The best way to avoid this problem is to only ever use either 'select' or
> 'depends on' for any given dependency, but not both. In this case, almost
> all references to PTP_1588_CLOCK use 'select' or 'implies', so I don't
> want to introduce any more 'depends on'.

I can't find any "select PTP_1588_CLOCK" in the tree.

The "imply" keyword in itself doesn't create nor inforce any 
dependencies -- that's why it was created in the first place.

So unless I'm mistaken I don't see any problem using "depends on 
PTP_1588_CLOCK" here.


Nicolas

Thread

[RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers Arnd Bergmann <arnd@arndb.de> - 2017-03-13 18:00 +0100
  Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-03-13 21:20 +0100
    Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers Arnd Bergmann <arnd@arndb.de> - 2017-03-13 21:30 +0100
      Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-03-13 21:50 +0100
        Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers Nicolas Pitre <nicolas.pitre@linaro.org> - 2017-03-13 22:00 +0100
          Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers Arnd Bergmann <arnd@arndb.de> - 2017-03-15 16:00 +0100

csiph-web