Re: x86/tsc: Fix ART for TSC_KNOWN_FREQ

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: x86/tsc: Fix ART for TSC_KNOWN_FREQ
Date	Mon, 13 Mar 2017 21:20:01 +0100
Message-ID	<tkEBH-5Mm-5@gated-at.bofh.it> (permalink)
References	<tkzC2-1Yl-13@gated-at.bofh.it> <tkDvX-501-7@gated-at.bofh.it>
X-Original-To	Thomas Gleixner <tglx@linutronix.de>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=w+z+bgfcYxVR1BJWyvYq/ft7ejSeemMncjXRNBaEQFI=; b=pPnNohwK0PbAlceVBxJ+1HCbT CovzRcsINkN58+WgAVl5fjSjiyaVsuWDKonHVZp/HIciIVOfCA6eaL1lJOudSHMCxaBQkurfvJvyv LqVUkClRlvKGe5hAN6zc+xXQs5eptUFcA6O8kadTP5u+6EhFbGZ7gG8do+Y3zPIu8M7A2E4eucmeI nkTehwXMTb5a5dckabPSZG+yPKJW847udEmooan6PZk70IXRbyAp47qc1iAsH+3cejekINQXcwaZg VTdWfEJqBkc2gGpz5Br2XZG/4685U1ecyol3kMm+xsBEVhKd6lWKCxRh53rOhW/Iv1ctrIZKES8zo nskODX5tw==;
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23.1 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, subhransu.s.prusty@intel.com, kevin.b.stanton@intel.com, akataria@vmware.com, john.stultz@linaro.org, christopher.s.hall@intel.com, Ingo Molnar <mingo@kernel.org>
X-Original-Date	Mon, 13 Mar 2017 21:12:14 +0100
X-Original-Message-ID	<20170313201214.GD3328@twins.programming.kicks-ass.net>
X-Original-References	<20170313145712.GI3312@twins.programming.kicks-ass.net> <alpine.DEB.2.20.1703131951400.3712@nanos>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1599777

Show key headers only | View raw

On Mon, Mar 13, 2017 at 08:04:14PM +0100, Thomas Gleixner wrote:
> On Mon, 13 Mar 2017, Peter Zijlstra wrote:
> 
> > 
> > Subhransu reported that convert_art_to_tsc() isn't working for him.
> > 
> > It turns out that because of commit:
> > 
> >   57779dc2b3b7 ("x86, tsc: Skip refined tsc calibration on systems with reliable TSC")
> 
> That's the wrong culprit. The problem was introduced with the ART support
> patches. I fixed the changelog up.

Right; thanks for untangling that history.

> > Systems with TSC_KNOWN_FREQ (due to having CPUID.15h) will not run the
> > refined calibration thing, and then forget to set the ART clocksource
> > relation.
> > 
> > We cannot set the ART relation prior to running the refined calibration;
> > therefore duplicate the lines.
> > 
> > XXX: should we clear this in mark_tsc_unstable() ?
>  
> It's already handled. get_device_system_timestamp() which convert ART to
> clock monotonic checks whether the timekeeper clocksource is the same as
> the correlated ART clocksource, i.e. TSC. So when timekeeping switches away
> from TSC get_device_system_timestamp() returns -ENODEV.

Ah right. Couldn't find that in a hurry.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

x86/tsc: Fix ART for TSC_KNOWN_FREQ Peter Zijlstra <peterz@infradead.org> - 2017-03-13 16:00 +0100
  [tip:x86/urgent] x86/tsc: Fix ART for TSC_KNOWN_FREQ tip-bot for Peter Zijlstra <tipbot@zytor.com> - 2017-03-13 20:00 +0100
  Re: x86/tsc: Fix ART for TSC_KNOWN_FREQ Thomas Gleixner <tglx@linutronix.de> - 2017-03-13 20:10 +0100
    Re: x86/tsc: Fix ART for TSC_KNOWN_FREQ Peter Zijlstra <peterz@infradead.org> - 2017-03-13 21:20 +0100

csiph-web