Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1599698

[PATCH v3 1/3] watchdog: s3c2410: Constify local structures

From Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups linux.kernel
Subject [PATCH v3 1/3] watchdog: s3c2410: Constify local structures
Date 2017-03-13 20:10 +0100
Message-ID <tkDvX-501-11@gated-at.bofh.it> (permalink)
References <tkDvX-501-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Structures watchdog_device, watchdog_ops and s3c2410_wdt_variant are not
modified so they can be made const to increase code safeness.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/watchdog/s3c2410_wdt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
index 6ed97596ca80..52b66bcdd1ef 100644
--- a/drivers/watchdog/s3c2410_wdt.c
+++ b/drivers/watchdog/s3c2410_wdt.c
@@ -131,7 +131,7 @@ struct s3c2410_wdt {
 	unsigned long		wtdat_save;
 	struct watchdog_device	wdt_device;
 	struct notifier_block	freq_transition;
-	struct s3c2410_wdt_variant *drv_data;
+	const struct s3c2410_wdt_variant *drv_data;
 	struct regmap *pmureg;
 };
 
@@ -401,7 +401,7 @@ static const struct watchdog_ops s3c2410wdt_ops = {
 	.restart = s3c2410wdt_restart,
 };
 
-static struct watchdog_device s3c2410_wdd = {
+static const struct watchdog_device s3c2410_wdd = {
 	.info = &s3c2410_wdt_ident,
 	.ops = &s3c2410wdt_ops,
 	.timeout = S3C2410_WATCHDOG_DEFAULT_TIME,
@@ -507,7 +507,7 @@ static inline unsigned int s3c2410wdt_get_bootstatus(struct s3c2410_wdt *wdt)
 	return 0;
 }
 
-static inline struct s3c2410_wdt_variant *
+static inline const struct s3c2410_wdt_variant *
 s3c2410_get_wdt_drv_data(struct platform_device *pdev)
 {
 	if (pdev->dev.of_node) {
-- 
2.9.3

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH v3 1/3] watchdog: s3c2410: Constify local structures Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-13 20:10 +0100
  Re: [PATCH v3 1/3] watchdog: s3c2410: Constify local structures Guenter Roeck <linux@roeck-us.net> - 2017-03-14 14:50 +0100
  Re: [PATCH v3 1/3] watchdog: s3c2410: Constify local structures Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 16:40 +0100

csiph-web