Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599654

Re: [PATCH] auxdisplay: use setup_timer

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Geliang,

On Friday, 10 March 2017 16:46:57 PDT Geliang Tang wrote:
> Use setup_timer() instead of init_timer() to simplify the code.
> 
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
>  drivers/auxdisplay/img-ascii-lcd.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/auxdisplay/img-ascii-lcd.c
> b/drivers/auxdisplay/img-ascii-lcd.c index bf43b5d..1f30b7e 100644
> --- a/drivers/auxdisplay/img-ascii-lcd.c
> +++ b/drivers/auxdisplay/img-ascii-lcd.c
> @@ -393,9 +393,7 @@ static int img_ascii_lcd_probe(struct platform_device
> *pdev) ctx->scroll_rate = HZ / 2;
> 
>  	/* initialise a timer for scrolling the message */
> -	init_timer(&ctx->timer);
> -	ctx->timer.function = img_ascii_lcd_scroll;
> -	ctx->timer.data = (unsigned long)ctx;
> +	setup_timer(&ctx->timer, img_ascii_lcd_scroll, (unsigned long)ctx);
> 
>  	platform_set_drvdata(pdev, ctx);

Thanks for the patch:

    Reviewed-by: Paul Burton <paul.burton@imgtec.com>

I've CC'd Ralf & Andrew since a couple of other patches to this driver have 
been waiting for someone to merge them for a while, and whilst it's unclear 
which path those patches & this one should take into mainline they've been 
suggested so far (besides Miguel who seems not to be active).

I've also CC'd the trivial patch monkey in case this can get in through that 
route, though I'm unsure whether CC'ing on a reply is sufficient so you might 
like to resend with trivial@kernel.org CC'd on the patch.

Thanks,
    Paul

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] auxdisplay: use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-03-11 01:50 +0100
  Re: [PATCH] auxdisplay: use setup_timer Paul Burton <paul.burton@imgtec.com> - 2017-03-13 18:30 +0100

csiph-web