Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for 4.10.1.

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for 4.10.1.
Date	Mon, 13 Mar 2017 18:10:02 +0100
Message-ID	<tkBDQ-3Ed-3@gated-at.bofh.it> (permalink)
References	<ti3Gi-2jy-13@gated-at.bofh.it> <ti5RL-3Nc-5@gated-at.bofh.it> <ti8wi-5Kt-29@gated-at.bofh.it> <tiNSO-1nX-13@gated-at.bofh.it> <tiSfL-4qJ-5@gated-at.bofh.it> <tj4gW-4pf-13@gated-at.bofh.it> <tjx9f-7F0-1@gated-at.bofh.it> <tjAA9-1nE-1@gated-at.bofh.it> <tkhc5-5PI-9@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+8Mi7nRrfxFFvs1Nmzi8DR4A6KW490jCNPlJ8K3bYeM=; b=H5sS2U35uk0h3nCSeFne5Ra63p4ieu2Zv4Y+vFxabSGPZDAhd4xxE4FL4/tHTIwxQG k5pCSMs4vf5p52KrBf3YTMNcwyoj5JC/Eq4Lj2EUKkaxuhfRIdrSddsx3XF8gf0YlCpR MSFWJNRu+TvHIXpjvPq0WwI/5ZRoMyV7+TYMpU5H15YjNJowL7kbi+jvfMb2torgsE08 C0o4OjXg9XhZmM2s3nf3IhDTRzPrqPYC5/dxbOdJ7fYarc3CjwftC5rYnFugtk9qErV0 pCqCnwrA0Ct+Ugn/Lofg6IATUYDP0cToKbWV68nRh2PYkSqJc4gmCy0V2mJ8SweTkKMB bQHQ==
X-Gm-Message-State	AFeK/H2nJu5EKA1lKNyKusw767o5BdnjeiOAcUDtq1j84O4QEnWGLRgHZPh8vzNLgBEPyw==
X-Received	by 10.28.155.65 with SMTP id d62mr11346740wme.7.1489424765266; Mon, 13 Mar 2017 10:06:05 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
User-Agent	Mutt/1.6.2-neo (2016-08-21)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski <m.szyprowski@samsung.com>
X-Original-Date	Mon, 13 Mar 2017 19:06:01 +0200
X-Original-Message-ID	<20170313170601.ozolfzgixqu6aa4g@kozik-lap>
X-Original-References	<CALaQ_hpC4G6CaxZAFvwNG3gFjc5Dj1C7zB6b_WQjGeYhbArHKw@mail.gmail.com> <20170306173511.6w3e47v4vomu7yv4@kozik-lap> <CALaQ_hqhFjb60rJ2AgBnYgyNCPQ7fH5BdOOCeaMiankQR0VwqQ@mail.gmail.com> <20170308174542.2rydwxmrb3oehyrc@kozik-lap> <20170308211543.euqexxlhdgpfcdjk@kozik-lap> <CALaQ_hrikH8Q8ug9WTgnYR3UwSCip1DZtkkjj2NCLJVqcKQdZA@mail.gmail.com> <20170310180640.dnacw53vqrqji2xo@kozik-lap> <CALaQ_hqomXaZs0z-S3YX6d-hS_giqgBqBSvumwsMm=BzrgZz7Q@mail.gmail.com> <20170312191322.bbux5nrkqf5klznq@kozik-lap>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1599633

Show key headers only | View raw

On Sun, Mar 12, 2017 at 09:13:22PM +0200, Krzysztof Kozlowski wrote:
> On Fri, Mar 10, 2017 at 03:44:45PM -0600, Nathan Royce wrote:
> > Sure, I went ahead and rebuilt it just using the bare exynos_defconfig
> > and adding XTS and ECB and no other changes.
> > 
> > No flags were used. No patches were used other than the 2 you
> > provided. Just the barest of bears, the barest of bones, the barest of
> > deserts, the barest of hairless cats.
> >
> 
> Okay, I reproduced it. Beside enabling crypto tests, ECB and XTS, the
> important step is to disable the "ARM Accelerated Cryptographic
> Algorithms" so S5P-SSS will be used with XTS. The xts(ecb-aes-s5p))
> itself passes TCRYPT tests but oopses on cryptswap.

Hi Herbert,

I bisected this to commit f1c131b45410 ("crypto: xts - Convert to
skcipher"). The s5p-sss driver stays the same... but the xts changes and
as a result we have a NULL pointer dereference (actually of value
00000004):
[   18.930195] Unable to handle kernel NULL pointer dereference at virtual address 00000004
...
[   18.972325] [<c0313c98>] (post_crypt) from [<c031408c>] (decrypt_done+0x4c/0x54)
[   18.972343] [<c031408c>] (decrypt_done) from [<c056309c>] (s5p_aes_interrupt+0x1bc/0x208)
[   18.972360] [<c056309c>] (s5p_aes_interrupt) from [<c0164930>] (irq_thread_fn+0x1c/0x54)

Any hints?

Best regards,
Krzysztof

Thread

Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for 4.10.1. Nathan Royce <nroycea+kernel@gmail.com> - 2017-03-06 17:30 +0100
  Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for  4.10.1. Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-06 19:50 +0100
    Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for  4.10.1. Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-08 18:50 +0100
      Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for  4.10.1. Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-08 23:30 +0100
        Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for 4.10.1. Nathan Royce <nroycea+kernel@gmail.com> - 2017-03-09 12:20 +0100
          Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for  4.10.1. Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-10 19:10 +0100
            Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for  4.10.1. Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-12 20:20 +0100
              Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for  4.10.1. Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-13 18:10 +0100
                Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for  4.10.1. Herbert Xu <herbert@gondor.apana.org.au> - 2017-03-14 10:30 +0100

csiph-web