Re: [PATCH 00/14] platform/x86: remove sparse_keymap_free() calls

Path	csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 00/14] platform/x86: remove sparse_keymap_free() calls
Date	Mon, 13 Mar 2017 17:20:02 +0100
Message-ID	<tkARs-34n-35@gated-at.bofh.it> (permalink)
References	<tj5cZ-523-3@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+ukqZVzVQfrFPVIHKRoKmliLiNx4cyDp6CpWNu26aY0=; b=rtS0lgQ5gMwGdAq905vUf5kTojqbBiS8gI8vWBOJzoR9UQXIsCxrAR5NkJGiTUCRB3 fXicq7WT4aovo6PzmpAk2SbH1Ch1lhyXQP9iLWWKLzuynMfylSm5OOSrfy0rtqVV2G1d dk1WKlFbm0oyGHJnN4/1rnbnwgOeA0COicOtq+9z2xVM1uHXkwyv9XE8RWGwJRhjU51M fH5CcTOJ7ngpBxuyiqb2R7uU+wO7De15E3o35K2uwYHJutvdMQRN7cAVdFH65gtD6aIH PZ9j9RtCZHI+XRcaUCfqqG162D7N29qt5yS2QMiWL6pxeaDlaomD/D5Qku8C8GYJUdkc 8YDQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+ukqZVzVQfrFPVIHKRoKmliLiNx4cyDp6CpWNu26aY0=; b=fxF4zT3LjnsBYKsa3KdPqtNJqfmS6+maJpGr+hEmxfleW0CNfw/eKooaSsXBUKVBbH 2QG9/gmq5RSrl5gty7OsjCKOoGeUzfWTJu57ZkkRBDjF236x1VR4rtHeRB9JzfC6yCia qjR59Zk1ZsZrgYwRLe6Tzm0GVGB3CJPIJC74s0fYKGHESHaWRL2fEHbpWuJpBb/96Pwj /j5P49AGwwuAONOR2Kzw31lENI3rnC4vPIKQWTKzWj6+Ad43B49eN29MNtaWsJeDT/Y9 mX3ZBF29tOQGJigYHUER9Kr4LtmjFGs8dalZm2s54EQ6xsE9BleA05vsQ0rLNasi0C9n 5y3w==
X-Gm-Message-State	AFeK/H3Sw6lWy0O3qziN+yS9Vu/nu1vs+H86FDwpZdHbC/EXyYmpH2mw+HmgHbrl6H52fy0ig+FnZW1E9xkt3g==
X-Received	by 10.55.135.7 with SMTP id j7mr30445024qkd.194.1489421505770; Mon, 13 Mar 2017 09:11:45 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	quoted-printable
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	52
Organization	linux.* mail to news gateway
X-Original-Cc	Andy Shevchenko <andy@infradead.org>, Azael Avalos <coproscefalo@gmail.com>, Corentin Chary <corentin.chary@gmail.com>, Darren Hart <dvhart@infradead.org>, Harald Welte <laforge@gnumonks.org>, Herton Ronaldo Krzesinski <herton@canonical.com>, Ike Panhc <ike.pan@canonical.com>, "Lee, Chun-Yi" <jlee@suse.com>, Matthew Garrett <mjg59@srcf.ucam.org>, Pali Rohár <pali.rohar@gmail.com>, acpi4asus-user <acpi4asus-user@lists.sourceforge.net>, Platform Driver <platform-driver-x86@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 13 Mar 2017 18:11:45 +0200
X-Original-Message-ID	<CAHp75VckmaCmEyimWq23MeUjpg2jMhfZVoTRYVxFCoSRJoSSZg@mail.gmail.com>
X-Original-References	<20170309121150.10553-1-kernel@kempniu.pl>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1599566

Show key headers only | View raw

On Thu, Mar 9, 2017 at 2:11 PM, Michał Kępień <kernel@kempniu.pl> wrote:
> Hi everyone,
>
> This patch series removes all uses of sparse_keymap_free() in the x86
> platform driver subsystem due to an upcoming change in
> sparse_keymap_setup() behavior wrt memory management.  Specifically,
> sparse_keymap_setup() will use managed memory for the keymap copy it
> creates, which enables it to be automatically freed upon input device
> removal, without the need to explicitly call sparse_keymap_free().
>
> I thought it makes sense to post all these patches as a single series.
> To minimize spamming, only this cover letter is addressed to all the
> maintainers whose drivers are affected by this series, while each of the
> subsequent patches will only be sent to the relevant recipients, plus
> the platform-driver-x86 mailing list and subsystem maintainers.
>
> Darren, Andy, all these patches should only be applied after merging an
> immutable branch called ib/4.10-sparse-keymap-managed from Dmitry
> Torokhov's git tree.

Pushed to testing.

If anyone has objections, please tell me as soon as possible (though
we have still time to remove / revert changes which I hope not the
case here).

>  drivers/platform/x86/acer-wmi.c         |  5 +----
>  drivers/platform/x86/asus-laptop.c      |  8 ++------
>  drivers/platform/x86/asus-wmi.c         |  8 ++------
>  drivers/platform/x86/dell-wmi-aio.c     |  6 +-----
>  drivers/platform/x86/dell-wmi.c         | 16 ++++------------
>  drivers/platform/x86/eeepc-laptop.c     |  8 ++------
>  drivers/platform/x86/hp-wmi.c           |  5 +----
>  drivers/platform/x86/ideapad-laptop.c   |  5 +----
>  drivers/platform/x86/msi-laptop.c       | 14 +++-----------
>  drivers/platform/x86/msi-wmi.c          |  9 ++-------
>  drivers/platform/x86/panasonic-laptop.c | 18 +++---------------
>  drivers/platform/x86/topstar-laptop.c   |  5 +----
>  drivers/platform/x86/toshiba-wmi.c      |  5 +----
>  drivers/platform/x86/toshiba_acpi.c     |  8 ++------
>  14 files changed, 26 insertions(+), 94 deletions(-)
>
> --
> 2.12.0
>



-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/14] platform/x86: remove sparse_keymap_free() calls Michał Kępień <kernel@kempniu.pl> - 2017-03-09 13:20 +0100
  [PATCH 07/14] platform/x86: hp-wmi: remove sparse_keymap_free() calls Michał Kępień <kernel@kempniu.pl> - 2017-03-09 13:20 +0100
  [PATCH 06/14] platform/x86: eeepc-laptop: remove sparse_keymap_free() calls Michał Kępień <kernel@kempniu.pl> - 2017-03-09 13:20 +0100
  [PATCH 04/14] platform/x86: dell-wmi-aio: remove sparse_keymap_free() calls Michał Kępień <kernel@kempniu.pl> - 2017-03-09 13:20 +0100
  [PATCH 10/14] platform/x86: msi-wmi: remove sparse_keymap_free() calls Michał Kępień <kernel@kempniu.pl> - 2017-03-09 13:20 +0100
  [PATCH 14/14] platform/x86: toshiba_acpi: remove sparse_keymap_free() calls Michał Kępień <kernel@kempniu.pl> - 2017-03-09 13:30 +0100
  Re: [PATCH 00/14] platform/x86: remove sparse_keymap_free() calls Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-13 17:20 +0100

csiph-web