[scsi] scsi: ufs: don't check unsigned type for a negative value

From	Tomas Winkler <tomas.winkler@intel.com>
Newsgroups	linux.kernel
Subject	[scsi] scsi: ufs: don't check unsigned type for a negative value
Date	2017-03-12 11:30 +0100
Message-ID	<tk8Vc-8tV-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Fix compilation warning

drivers/scsi/ufs/ufshcd.c:7645:13: warning: comparison of unsigned
expression < 0 is always false [-Wtype-limits]
if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX))

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 drivers/scsi/ufs/ufshcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1359913bf840..e8c26e6e6237 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -7642,7 +7642,7 @@ static inline ssize_t ufshcd_pm_lvl_store(struct device *dev,
 	if (kstrtoul(buf, 0, &value))
 		return -EINVAL;
 
-	if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX))
+	if (value >= UFS_PM_LVL_MAX)
 		return -EINVAL;
 
 	spin_lock_irqsave(hba->host->host_lock, flags);
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[scsi] scsi: ufs: don't check unsigned type for a negative value Tomas Winkler <tomas.winkler@intel.com> - 2017-03-12 11:30 +0100
  Re: [scsi] scsi: ufs: don't check unsigned type for a negative value Subhash Jadavani <subhashj@codeaurora.org> - 2017-03-14 01:20 +0100

csiph-web