[PATCH] um: use KERN_CONT in stack dump

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Vegard Nossum <vegard.nossum@oracle.com>
Newsgroups	linux.kernel
Subject	[PATCH] um: use KERN_CONT in stack dump
Date	Sun, 12 Mar 2017 10:40:02 +0100
Message-ID	<tk88O-7Y2-13@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 2.12.0.rc0
X-Source-IP	aserv0021.oracle.com [141.146.126.233]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	52
Organization	linux.* mail to news gateway
X-Original-Cc	user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Vegard Nossum <vegard.nossum@oracle.com>
X-Original-Date	Sun, 12 Mar 2017 10:38:20 +0100
X-Original-Message-ID	<20170312093820.12044-1-vegard.nossum@oracle.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1598564

Show key headers only | View raw

Without KERN_CONT, the symbol will appear on a new line, making stack
traces completely unreadable:

    Call Trace:
     [<6008e891>] ?
    printk+0x0/0x94
     [<6001cce6>]
    show_stack+0xfe/0x15b
     [<600666ec>] ?
    dump_stack_print_info+0xe1/0xea
     [<6008e891>] ?
    printk+0x0/0x94
     [<6023e826>] ?
    bust_spinlocks+0x0/0x4f
     [<602343b8>]
    dump_stack+0x2a/0x2c
     [<6008e662>]
    panic+0x170/0x31e
     [<6008e4f2>] ?
    panic+0x0/0x31e

This makes it readable again:

    Call Trace:
     [<6008e891>] ? printk+0x0/0x94
     [<6001cce6>] show_stack+0xfe/0x15b
     [<600666ec>] ? dump_stack_print_info+0xe1/0xea
     [<6008e891>] ? printk+0x0/0x94
     [<6023e826>] ? bust_spinlocks+0x0/0x4f
     [<602343b8>] dump_stack+0x2a/0x2c
     [<6008e662>] panic+0x170/0x31e

Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
---
 arch/um/kernel/sysrq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c
index a76295f7ede9..edf1f80123e7 100644
--- a/arch/um/kernel/sysrq.c
+++ b/arch/um/kernel/sysrq.c
@@ -22,7 +22,7 @@ static void _print_addr(void *data, unsigned long address, int reliable)
 {
 	pr_info(" [<%08lx>]", address);
 	pr_cont(" %s", reliable ? "" : "? ");
-	print_symbol("%s", address);
+	print_symbol(KERN_CONT "%s", address);
 	pr_cont("\n");
 }
 
-- 
2.12.0.rc0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] um: use KERN_CONT in stack dump Vegard Nossum <vegard.nossum@oracle.com> - 2017-03-12 10:40 +0100
  Re: [PATCH] um: use KERN_CONT in stack dump Vegard Nossum <vegard.nossum@oracle.com> - 2017-03-12 10:50 +0100
  Re: [PATCH] um: use KERN_CONT in stack dump Richard Weinberger <richard@nod.at> - 2017-03-12 10:50 +0100

csiph-web