Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1598542

Re: [PATCH] staging: sm750fb: Improved coding style

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: sm750fb: Improved coding style
Date 2017-03-12 05:50 +0100
Message-ID <tk3C9-4Nm-7@gated-at.bofh.it> (permalink)
References <tk1Al-3lE-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, Mar 12, 2017 at 08:04:02AM +0530, Arushi Singhal wrote:
> New variables are added to make the code more readable.
> Also fixed the checkpatch issue: "Alignment should match open
> parenthesis".

When you have to say "also" in a commit message, that is a huge red-flag
that you need to break a patch up into different parts, as you are doing
multiple things.  Please do so here.

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] staging: sm750fb: Improved coding style Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-12 03:40 +0100
  Re: [PATCH] staging: sm750fb: Improved coding style Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-12 05:50 +0100
  Re: [PATCH] staging: sm750fb: Improved coding style kbuild test robot <lkp@intel.com> - 2017-03-12 22:40 +0100

csiph-web