Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1598065
| From | Theodore Ts'o <tytso@mit.edu> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4.4 49/91] ext4: preserve the needs_recovery flag when the journal is aborted |
| Date | 2017-03-10 21:20 +0100 |
| Message-ID | <tjzb3-yL-13@gated-at.bofh.it> (permalink) |
| References | <tjoSl-1MV-3@gated-at.bofh.it> <tjtS3-5k0-23@gated-at.bofh.it> <tjw3w-6JY-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Mar 10, 2017 at 04:58:02PM +0000, Ben Hutchings wrote:
> > ---
> > fs/ext4/super.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > --- a/fs/ext4/super.c
> > +++ b/fs/ext4/super.c
> [...]
> > @@ -802,9 +803,10 @@ static void ext4_put_super(struct super_
> > destroy_workqueue(sbi->rsv_conversion_wq);
> >
> > if (sbi->s_journal) {
> > + aborted = is_journal_aborted(sbi->s_journal);
> > err = jbd2_journal_destroy(sbi->s_journal);
> > sbi->s_journal = NULL;
> > - if (err < 0)
> > + if ((err < 0) && !aborted)
> > ext4_abort(sb, "Couldn't clean up the journal");
> [...]
>
> Shouldn't the aborted flag also be set here when err < 0?
Nice catch. That's a separate issue (the bug was there before this
commit), though I'll send a separate patch to fix this in mainline and
then cc stable, OK?
- Ted
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4.4 49/91] ext4: preserve the needs_recovery flag when the journal is aborted Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-10 15:40 +0100
Re: [PATCH 4.4 49/91] ext4: preserve the needs_recovery flag when the journal is aborted Ben Hutchings <ben@decadent.org.uk> - 2017-03-10 18:00 +0100
Re: [PATCH 4.4 49/91] ext4: preserve the needs_recovery flag when the journal is aborted Theodore Ts'o <tytso@mit.edu> - 2017-03-10 21:20 +0100
Re: [PATCH 4.4 49/91] ext4: preserve the needs_recovery flag when the journal is aborted Ben Hutchings <ben@decadent.org.uk> - 2017-03-11 06:30 +0100
csiph-web