Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1598020
| From | David Lin <dtwlin@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] jump label: fix passing kbuild_cflags when checking for asm goto support |
| Date | 2017-03-10 19:40 +0100 |
| Message-ID | <tjxCi-7Rw-27@gated-at.bofh.it> (permalink) |
| References | <tjvAt-6xJ-3@gated-at.bofh.it> <tjwdb-72n-3@gated-at.bofh.it> <tjwPT-7iA-3@gated-at.bofh.it> <tjwPT-7iA-1@gated-at.bofh.it> <tjwZA-7md-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Mar 10, 2017 at 9:55 AM, Gleb Fotengauer-Malinovskiy
<glebfm@altlinux.org> wrote:
>
> The latest change of asm goto support check added passing of KBUILD_CFLAGS
> to compiler. When these flags reference gcc plugins that are not built yet,
> the check fails.
>
> When one runs "make bzImage" followed by "make modules", the kernel is always
> built with HAVE_JUMP_LABEL disabled, while the modules are built depending on
> CONFIG_JUMP_LABEL. If HAVE_JUMP_LABEL macro happens to be different, modules
> are built with undefined references, e.g.:
>
> ERROR: "static_key_slow_inc" [net/netfilter/xt_TEE.ko] undefined!
> ERROR: "static_key_slow_dec" [net/netfilter/xt_TEE.ko] undefined!
> ERROR: "static_key_slow_dec" [net/netfilter/nft_meta.ko] undefined!
> ERROR: "static_key_slow_inc" [net/netfilter/nft_meta.ko] undefined!
> ERROR: "nf_hooks_needed" [net/netfilter/ipvs/ip_vs.ko] undefined!
> ERROR: "nf_hooks_needed" [net/ipv6/ipv6.ko] undefined!
> ERROR: "static_key_count" [net/ipv6/ipv6.ko] undefined!
> ERROR: "static_key_slow_inc" [net/ipv6/ipv6.ko] undefined!
>
> This change moves the check before all these references are added
> to KBUILD_CFLAGS. This is correct because subsequent KBUILD_CFLAGS
> modifications are not relevant to this check.
>
> Reported-by: Anton V. Boyarshinov <boyarsh@altlinux.org>
> Fixes: 35f860f9ba6a ("jump label: pass kbuild_cflags when checking for asm goto support")
> Cc: stable@vger.kernel.org # v4.10
> Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
Acked-by: David Lin <dtwlin@google.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] jump label: fix passing kbuild_cflags when checking for asm goto support Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> - 2017-03-10 17:30 +0100
Re: [PATCH] jump label: fix passing kbuild_cflags when checking for asm goto support Steven Rostedt <rostedt@goodmis.org> - 2017-03-10 18:10 +0100
Re: [PATCH] jump label: fix passing kbuild_cflags when checking for asm goto support Steven Rostedt <rostedt@goodmis.org> - 2017-03-10 18:50 +0100
[PATCH v2] jump label: fix passing kbuild_cflags when checking for asm goto support Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> - 2017-03-10 19:00 +0100
Re: [PATCH v2] jump label: fix passing kbuild_cflags when checking for asm goto support Steven Rostedt <rostedt@goodmis.org> - 2017-03-10 19:10 +0100
Re: [PATCH v2] jump label: fix passing kbuild_cflags when checking for asm goto support David Lin <dtwlin@google.com> - 2017-03-10 19:40 +0100
Re: [PATCH] jump label: fix passing kbuild_cflags when checking for asm goto support Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> - 2017-03-10 18:50 +0100
csiph-web