[PATCH RFC] virtio_net: fix mergeable bufs error handling

From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH RFC] virtio_net: fix mergeable bufs error handling
Date	2017-03-10 17:20 +0100
Message-ID	<tjvqO-6uM-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

On xdp error we try to free head_skb without having
initialized it, that's clearly bogus.

Fixes: f600b6905015 ("virtio_net: Add XDP support")
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

I'm cleaning up a bunch of issues in this code, thus
RFC, will test and post it all together.

 drivers/net/virtio_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 11773d6..e0fb3707 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -570,7 +570,7 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
 	u16 num_buf;
 	struct page *page;
 	int offset;
-	struct sk_buff *head_skb, *curr_skb;
+	struct sk_buff *head_skb = NULL, *curr_skb;
 	struct bpf_prog *xdp_prog;
 	unsigned int truesize;
 
-- 
MST

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH RFC] virtio_net: fix mergeable bufs error handling "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-10 17:20 +0100

csiph-web