Re: [PATCH 1/2] mfd: retu: Add OF device ID table

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] mfd: retu: Add OF device ID table
Date	2017-03-10 14:30 +0100
Message-ID	<tjsMk-4Ar-73@gated-at.bofh.it> (permalink)
References	<tdiPD-3ak-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Lee,

On 02/21/2017 10:34 AM, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
> 
> But this could change in the future so the correct approach is to have a
> OF device ID table if the devices are registered via OF.
> 
> The compatible strings don't have a vendor prefix because that's how it's
> used currently, and changing this will be a Device Tree ABI break.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---

Any comment on this patch and 2/2?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] mfd: retu: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-10 14:30 +0100

csiph-web