Re: [PATCH v3] usb: gadget: udc: remove pointer dereference after free

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] usb: gadget: udc: remove pointer dereference after free
Date	2017-03-10 12:40 +0100
Message-ID	<tjr3P-3kY-1@gated-at.bofh.it> (permalink)
References	(2 earlier) <t8Iro-5Hm-23@gated-at.bofh.it> <t9Jlo-3na-15@gated-at.bofh.it> <tarmq-5YZ-23@gated-at.bofh.it> <taDnA-5m6-5@gated-at.bofh.it> <taDnA-5m6-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

"Gustavo A. R. Silva" <garsilva@embeddedor.com> writes:

> Remove pointer dereference after free.
>
> Addresses-Coverity-ID: 1091173
> Acked-by: Michal Nazarewicz <mina86@mina86.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> Changes in v2:
>   Move pointer dereference before pci_pool_free()
>   Set pointer to NULL after free
>
> Changes in v3:
>   Remove 'td->next = 0x00' inside for loop.
>   Remove unnecessary pointer nullification after free.
>
>   drivers/usb/gadget/udc/pch_udc.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/pch_udc.c  
> b/drivers/usb/gadget/udc/pch_udc.c
> index a97da64..8a365aa 100644
> --- a/drivers/usb/gadget/udc/pch_udc.c
> +++ b/drivers/usb/gadget/udc/pch_udc.c
> @@ -1523,7 +1523,6 @@ static void pch_udc_free_dma_chain(struct  
> pch_udc_dev *dev,

line wrapped. Can't apply.

-- 
balbi

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] usb: gadget: udc: remove pointer dereference after free Felipe Balbi <balbi@kernel.org> - 2017-03-10 12:40 +0100
  Re: [PATCH v3] usb: gadget: udc: remove pointer dereference after  free "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-03-10 22:30 +0100
    [PATCH v4] usb: gadget: udc: remove pointer dereference after free "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-03-10 22:40 +0100

csiph-web