RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type
Date	2017-03-10 12:30 +0100
Message-ID	<tjqUa-3fF-23@gated-at.bofh.it> (permalink)
References	<t9e7U-tH-25@gated-at.bofh.it> <t9e7U-tH-27@gated-at.bofh.it> <t9e7U-tH-23@gated-at.bofh.it> <t9f3Y-140-5@gated-at.bofh.it> <t9lsJ-5dQ-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Jerry Huang <jerry.huang@nxp.com> writes:
>> >> --
>> >> 1.7.9.5
>> > Hi, Balbi and all guys,
>> > Any comment for these patches? Can they be accepted?
>> 
>> Rob had comments which you didn't reply yet. I cannot take this patchset
>> yet ;-)
>> 
> Balbi,
>
> I look into his mail again, which was based v3, and I replied it.
>
> He had different understanding for undefined length burst mode.
>
> It seems he think for this mode, just setting bit[0] (INCRBrstEna) and
> don't need to set other field.
>
> However, according to the DWC USB3.0 controller databook, when it is
> undefined length INCR burst mode, we still need to set one max burst
> type, such as INCR8, which means controller will use any length less
> than or equal to this INCR8.

Rob, do you agree with the patch now?

-- 
balbi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type Felipe Balbi <balbi@kernel.org> - 2017-03-10 12:30 +0100

csiph-web