Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1596672
| From | Vivek Gautam <vivek.gautam@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 3/4] dt-bindings: phy: Add support for QMP phy |
| Date | 2017-03-10 07:20 +0100 |
| Message-ID | <tjm49-83z-5@gated-at.bofh.it> (permalink) |
| References | <tj2f8-35K-17@gated-at.bofh.it> <tj2oO-397-21@gated-at.bofh.it> <tj47h-4lW-53@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/09/2017 04:37 PM, Bjorn Andersson wrote:
> On Thu 09 Mar 10:07 CET 2017, Vivek Gautam wrote:
>
> [..]
>> + phy@34000 {
>> + compatible = "qcom,msm8996-qmp-pcie-phy";
>> + reg = <0x034000 0x488>;
> Drop the leading 0 from the address.
Okay, will drop it.
>
>> + #clock-cells = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
>> +
>> + clocks = <&gcc GCC_PCIE_PHY_AUX_CLK>,
>> + <&gcc GCC_PCIE_PHY_CFG_AHB_CLK>,
>> + <&gcc GCC_PCIE_CLKREF_CLK>;
>> + clock-names = "aux", "cfg_ahb", "ref";
>> +
>> + vdda-phy-supply = <&pm8994_l28>;
>> + vdda-pll-supply = <&pm8994_l12>;
>> +
>> + resets = <&gcc GCC_PCIE_PHY_BCR>,
>> + <&gcc GCC_PCIE_PHY_COM_BCR>,
>> + <&gcc GCC_PCIE_PHY_COM_NOCSR_BCR>;
>> + reset-names = "phy", "common", "cfg";
>> +
>> + pciephy_0: lane@0 {
> The "@xyz" part should match the first value in "reg", i.e. 35000 here.
Right, i think this came from my older version of patches. Will correct it.
Regards
Vivek
>
>> + reg = <0x035000 0x130>,
>> + <0x035200 0x200>,
>> + <0x035400 0x1dc>;
>> + #phy-cells = <0>;
>> +
>> + clocks = <&gcc GCC_PCIE_0_PIPE_CLK>;
>> + clock-names = "pipe0";
>> + resets = <&gcc GCC_PCIE_0_PHY_BCR>;
>> + reset-names = "lane0";
>> + };
>> +
>> + pciephy_1: lane@1 {
>> + ...
>> + ...
>> + };
> Regards,
> Bjorn
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 0/4] phy: USB and PCIe phy drivers for Qcom chipsets Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-03-09 10:10 +0100
[PATCH v5 3/4] dt-bindings: phy: Add support for QMP phy Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-03-09 10:20 +0100
Re: [PATCH v5 3/4] dt-bindings: phy: Add support for QMP phy Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-03-09 12:10 +0100
Re: [PATCH v5 3/4] dt-bindings: phy: Add support for QMP phy Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-03-10 07:20 +0100
Re: [PATCH v5 4/4] phy: qcom-qmp: new qmp phy driver for qcom-chipsets Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-03-09 12:50 +0100
csiph-web