[RFC] mm/compaction: ignore block suitable after check large free page

From	Yisheng Xie <xieyisheng1@huawei.com>
Newsgroups	linux.kernel
Subject	[RFC] mm/compaction: ignore block suitable after check large free page
Date	2017-03-10 05:30 +0100
Message-ID	<tjklI-6LR-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If the migrate target is a large free page and we ignore suitable,
it may not good for defrag. So move the ignore block suitable after
check large free page.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
---
 mm/compaction.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 0fdfde0..4bf2a5d 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -991,9 +991,6 @@ static bool too_many_isolated(struct zone *zone)
 static bool suitable_migration_target(struct compact_control *cc,
 							struct page *page)
 {
-	if (cc->ignore_block_suitable)
-		return true;
-
 	/* If the page is a large free page, then disallow migration */
 	if (PageBuddy(page)) {
 		/*
@@ -1005,6 +1002,9 @@ static bool suitable_migration_target(struct compact_control *cc,
 			return false;
 	}
 
+	if (cc->ignore_block_suitable)
+		return true;
+
 	/* If the block is MIGRATE_MOVABLE or MIGRATE_CMA, allow migration */
 	if (migrate_async_suitable(get_pageblock_migratetype(page)))
 		return true;
-- 
1.7.12.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC] mm/compaction: ignore block suitable after check large free page Yisheng Xie <xieyisheng1@huawei.com> - 2017-03-10 05:30 +0100
  Re: [RFC] mm/compaction: ignore block suitable after check large free  page Vlastimil Babka <vbabka@suse.cz> - 2017-03-10 08:40 +0100
    Re: [RFC] mm/compaction: ignore block suitable after check large free  page Yisheng Xie <xieyisheng1@huawei.com> - 2017-03-10 11:00 +0100
      Re: [RFC] mm/compaction: ignore block suitable after check large free  page Vlastimil Babka <vbabka@suse.cz> - 2017-03-13 11:00 +0100
        Re: [RFC] mm/compaction: ignore block suitable after check large free  page Yisheng Xie <xieyisheng1@huawei.com> - 2017-03-13 13:20 +0100

csiph-web