Re: [PATCH net, v1] dccp/tcp: fix routing redirect race

From	Jonathan Maxwell <jmaxwell37@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net, v1] dccp/tcp: fix routing redirect race
Date	2017-03-10 06:10 +0100
Message-ID	<tjkYp-7iw-7@gated-at.bofh.it> (permalink)
References	<tjjzj-6cJ-3@gated-at.bofh.it> <tjklI-6LR-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 10, 2017 at 3:23 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Fri, 2017-03-10 at 14:31 +1100, Jon Maxwell wrote:
>> As Eric Dumazet pointed out this also needs to be fixed in IPv6.
>> v1: Contains the IPv6 patch as well.
>
>> Fixes: ceb3320610d6 ("ipv4: Kill routes during PMTU/redirect updates.")
>> Cc: Eric Garver <egarver@redhat.com>
>> Cc: Hannes Sowa <hsowa@redhat.com>
>> Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
>> ---
>>  net/dccp/ipv4.c     | 3 ++-
>>  net/ipv4/tcp_ipv4.c | 3 ++-
>>  net/ipv6/tcp_ipv6.c | 8 +++++---
>
> Hi Jon.
>
> You forgot net/dccp/ipv6.c
>
> dccp_v6_err() has the same issue.
>
>

Thanks Eric,

My bad. I'll fix that and post another patch.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net, v1] dccp/tcp: fix routing redirect race Jon Maxwell <jmaxwell37@gmail.com> - 2017-03-10 04:40 +0100
  Re: [PATCH net, v1] dccp/tcp: fix routing redirect race Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-10 05:30 +0100
    Re: [PATCH net, v1] dccp/tcp: fix routing redirect race Jonathan Maxwell <jmaxwell37@gmail.com> - 2017-03-10 06:10 +0100

csiph-web