Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1596568

Re: [PATCH 1/3] PCI: rockchip: fix sign issues for current limits

Show all headers | View raw

On Thu, Mar 09, 2017 at 04:59:15PM +0800, Shawn Lin wrote:
> On 2017/3/9 7:37, Brian Norris wrote:
> >The regulator framework can return negative error codes via
> >regulator_get_current_limit() for regulators that don't provide current
> >information. The subsequent check for postive values isn't very useful,
> >if the variable is unsigned.
> >
> >Let's just match the signedness of the return value.
> >
> >Prevents error messages like this, seen on Samsung Chromebook Plus:
> >
> >[    1.069372] rockchip-pcie f8000000.pcie: invalid power supply
> >
> 
> For this patch,
> 
> Acked-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks.

> And I think patch 2 is not so urgent so we could just wait for your
> non-WIP patch 3?

Sure. I'll be resending the series with a proper patch 3 (and 4 and 5
actually) soon anyway. No changes to the first 2.

Brian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] PCI: rockchip: fix sign issues for current limits Brian Norris <briannorris@chromium.org> - 2017-03-09 00:40 +0100
  [PATCH 2/3] PCI: rockchip: make 'return 0' more obvious in probe() Brian Norris <briannorris@chromium.org> - 2017-03-09 00:40 +0100
  [RFC PATCH 3/3] WIP: PCI: rockchip: add remove() support Brian Norris <briannorris@chromium.org> - 2017-03-09 00:40 +0100
    Re: [RFC PATCH 3/3] WIP: PCI: rockchip: add remove() support Brian Norris <briannorris@chromium.org> - 2017-03-09 04:20 +0100
  Re: [PATCH 1/3] PCI: rockchip: fix sign issues for current limits Shawn Lin <shawn.lin@rock-chips.com> - 2017-03-09 10:00 +0100
    Re: [PATCH 1/3] PCI: rockchip: fix sign issues for current limits Brian Norris <briannorris@chromium.org> - 2017-03-10 03:30 +0100

csiph-web