Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1596578
| From | Brian Norris <briannorris@chromium.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 2/5] PCI: rockchip: make 'return 0' more obvious in probe() |
| Date | 2017-03-10 03:50 +0100 |
| Message-ID | <tjiMV-5zt-1@gated-at.bofh.it> (permalink) |
| References | <tjiMV-5zt-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
There's no way to get here with 'err != 0'. Just return 0 to be more obvious and prevent future changes from accidentally erroring out here without going through the right error paths. Signed-off-by: Brian Norris <briannorris@chromium.org> --- v2: no change --- drivers/pci/host/pcie-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c index d785f64ec03b..5d7b27b1e941 100644 --- a/drivers/pci/host/pcie-rockchip.c +++ b/drivers/pci/host/pcie-rockchip.c @@ -1398,7 +1398,7 @@ static int rockchip_pcie_probe(struct platform_device *pdev) pcie_bus_configure_settings(child); pci_bus_add_devices(bus); - return err; + return 0; err_free_res: pci_free_resource_list(&res); -- 2.12.0.246.ga2ecc84866-goog
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH v2 2/5] PCI: rockchip: make 'return 0' more obvious in probe() Brian Norris <briannorris@chromium.org> - 2017-03-10 03:50 +0100
csiph-web