Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1596536

Re: [PATCH] f2fs: add fault injection on f2fs_truncate

From Chao Yu <yuchao0@huawei.com>
Newsgroups linux.kernel
Subject Re: [PATCH] f2fs: add fault injection on f2fs_truncate
Date 2017-03-10 02:20 +0100
Message-ID <tjhnQ-4Ms-7@gated-at.bofh.it> (permalink)
References <tjfFq-3B9-87@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Jaegeuk,

At a glance, it needs to add one more entry in fault_name as well. :)

Thanks,

On 2017/3/10 7:28, Jaegeuk Kim wrote:
> Inject a fault during f2fs_truncate().
> 
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/f2fs.h | 1 +
>  fs/f2fs/file.c | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 870bb4d9bc65..7edb3bea15a4 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -50,6 +50,7 @@ enum {
>  	FAULT_BLOCK,
>  	FAULT_DIR_DEPTH,
>  	FAULT_EVICT_INODE,
> +	FAULT_TRUNCATE,
>  	FAULT_IO,
>  	FAULT_CHECKPOINT,
>  	FAULT_MAX,
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 0110c263a705..4ec764ea89bd 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -620,6 +620,12 @@ int f2fs_truncate(struct inode *inode)
>  
>  	trace_f2fs_truncate(inode);
>  
> +#ifdef CONFIG_F2FS_FAULT_INJECTION
> +	if (time_to_inject(F2FS_I_SB(inode), FAULT_TRUNCATE)) {
> +		f2fs_show_injection_info(FAULT_TRUNCATE);
> +		return -EIO;
> +	}
> +#endif
>  	/* we should check inline_data size */
>  	if (!f2fs_may_inline_data(inode)) {
>  		err = f2fs_convert_inline_inode(inode);
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] f2fs: add fault injection on f2fs_truncate Jaegeuk Kim <jaegeuk@kernel.org> - 2017-03-10 00:30 +0100
  Re: [PATCH] f2fs: add fault injection on f2fs_truncate Chao Yu <yuchao0@huawei.com> - 2017-03-10 02:20 +0100
  Re: [PATCH v2] f2fs: add fault injection on f2fs_truncate Jaegeuk Kim <jaegeuk@kernel.org> - 2017-03-10 03:00 +0100

csiph-web