[PATCH v1 2/7] staging: gc2235: Add blank line after a declaration

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	simran singhal <singhalsimran0@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v1 2/7] staging: gc2235: Add blank line after a declaration
Date	Fri, 10 Mar 2017 00:00:02 +0100
Message-ID	<tjfcm-3bj-29@gated-at.bofh.it> (permalink)
References	<tjfcl-3bj-3@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8uaMIW9r/sn2NstsmyJ7fwHTvP7JYjmGFvPuOoGiHZ4=; b=KLqxkVJDBmdo9xmGzb8DgfAZ8XiQlOmsFkvsmUOjLD6drp/3eM6Um78gGh0rDBwinb wa3zCaDJNXyPW3vAfxNvjtWgfScG46QZNVsQXyY/zV4RXu+xxd8vcodOH+0eSd0QHpEA bB5jiCcAQsZOX6bM60NKdzwed/AN4hhT/++gCdebSl3WFXPj+MBcivpO3drdGURrZbUb D9+Sz6bpTcMnfj/lEsi5JyxyxOh1iVYR2BDkmu4QVH2lUA5gJSjn2WZ7VshuiTPq8L4/ Z32Lp5Ov84/LD3YQgQwsnVuXQSEp08msA+pXQPcKMrAUhLn36VGDIoaN8qsYjMbeor/s lejQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8uaMIW9r/sn2NstsmyJ7fwHTvP7JYjmGFvPuOoGiHZ4=; b=YAygwWUV3HlYxshJqcbKfXPk9Ilc9LkP1lnemv8i2OaX3rbUmz2XiWYkkbnNTw6PTE vDHOrjiaW+J5JLKBMLSwADhofSwC7lqEHEPS6dnzgP7Fjg84mLzKimB2aYgXbVAF5a04 Yyz1NY8ApnUKk19ppcBVoq2+cZl/2YIJ3TkgKQOSlnw6faiLX9mtULBW3TXRJkw8p55g csg8yEyiOSrgAoNXRChJzNoZDzE43/AADr6+3sMmoB6STblSn48Ynnx4mFIAG4yx6Xgw JdXCjdfmRUZA7d1uz0Jx/zGOIEqGGLMM1TdkWVvMhO1oPhHbRZ43W+G0Hr6A4yWgZ1Cn towA==
X-Gm-Message-State	AMke39mVwiZ3azFzSnLEQqhC6RkkGkTcA8xMT7/T2xW/D/UGyTq47pUsbWbsP0MkR9ohmA==
X-Received	by 10.98.160.193 with SMTP id p62mr16971239pfl.67.1489099841577; Thu, 09 Mar 2017 14:50:41 -0800 (PST)
X-Mailer	git-send-email 2.7.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	73
Organization	linux.* mail to news gateway
X-Original-Cc	gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
X-Original-Date	Fri, 10 Mar 2017 04:20:24 +0530
X-Original-Message-ID	<1489099829-1264-3-git-send-email-singhalsimran0@gmail.com>
X-Original-References	<1489099829-1264-1-git-send-email-singhalsimran0@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1596461

Show key headers only | View raw

Add blank line after a declaration. Problem found
using checkpatch.

This patch fixes these warning messages found by checkpatch.pl:
WARNING : Missing a blank line after declarations.

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/media/atomisp/i2c/gc2235.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/staging/media/atomisp/i2c/gc2235.c b/drivers/staging/media/atomisp/i2c/gc2235.c
index 3f2b11ec..7de7e24 100644
--- a/drivers/staging/media/atomisp/i2c/gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/gc2235.c
@@ -359,6 +359,7 @@ static long __gc2235_set_exposure(struct v4l2_subdev *sd, int coarse_itg,
 	u16 coarse_integration = (u16)coarse_itg;
 	int ret = 0;
 	u16 expo_coarse_h, expo_coarse_l, gain_val = 0xF0, gain_val2 = 0xF0;
+
 	expo_coarse_h = coarse_integration>>8;
 	expo_coarse_l = coarse_integration & 0xff;
 
@@ -410,6 +411,7 @@ static long gc2235_s_exposure(struct v4l2_subdev *sd,
 	/* we should not accept the invalid value below. */
 	if (gain == 0) {
 		struct i2c_client *client = v4l2_get_subdevdata(sd);
+
 		v4l2_err(client, "%s: invalid value\n", __func__);
 		return -EINVAL;
 	}
@@ -546,6 +548,7 @@ static int is_init;
 static int gc2235_init(struct v4l2_subdev *sd)
 {
 	int ret = 0;
+
 	ret = __gc2235_init(sd);
 
 	return ret;
@@ -759,6 +762,7 @@ static int startup(struct v4l2_subdev *sd)
 	struct gc2235_device *dev = to_gc2235_sensor(sd);
 	struct i2c_client *client = v4l2_get_subdevdata(sd);
 	int ret = 0;
+
 	if (is_init == 0) {
 		/* force gc2235 to do a reset in res change, otherwise it
 		* can not output normal after switching res. and it is not
@@ -893,6 +897,7 @@ static int gc2235_s_stream(struct v4l2_subdev *sd, int enable)
 	struct gc2235_device *dev = to_gc2235_sensor(sd);
 	struct i2c_client *client = v4l2_get_subdevdata(sd);
 	int ret;
+
 	mutex_lock(&dev->input_lock);
 
 	if (enable)
@@ -1007,6 +1012,7 @@ static int gc2235_s_parm(struct v4l2_subdev *sd,
 			struct v4l2_streamparm *param)
 {
 	struct gc2235_device *dev = to_gc2235_sensor(sd);
+
 	dev->run_mode = param->parm.capture.capturemode;
 
 	mutex_lock(&dev->input_lock);
@@ -1112,6 +1118,7 @@ static int gc2235_remove(struct i2c_client *client)
 {
 	struct v4l2_subdev *sd = i2c_get_clientdata(client);
 	struct gc2235_device *dev = to_gc2235_sensor(sd);
+
 	dev_dbg(&client->dev, "gc2235_remove...\n");
 
 	if (dev->platform_data->platform_deinit)
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/7] staging: gc2235: Multiple checkpatch issues simran singhal <singhalsimran0@gmail.com> - 2017-03-10 00:00 +0100
  [PATCH v1 4/7] staging: gc2235: Remove blank line before '}' and after '{' braces simran singhal <singhalsimran0@gmail.com> - 2017-03-10 00:00 +0100
  [PATCH v1 2/7] staging: gc2235: Add blank line after a declaration simran singhal <singhalsimran0@gmail.com> - 2017-03-10 00:00 +0100

csiph-web