Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1596399
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Outreachy kernel] [PATCH 5/6] staging: speakup: Alignment should match open parenthesis |
| Date | 2017-03-09 22:40 +0100 |
| Message-ID | <tjdWV-2rg-5@gated-at.bofh.it> (permalink) |
| References | <tjbBL-10C-5@gated-at.bofh.it> <tjbBM-10C-49@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 10 Mar 2017, Arushi Singhal wrote:
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> if (synth_request_region(speakup_info.port_tts - 1,
> - SYNTH_IO_EXTENT)) {
> + SYNTH_IO_EXTENT)) {
> pr_warn("sorry, port already reserved\n");
> return -EBUSY;
> }
> @@ -270,7 +270,7 @@ static int synth_probe(struct spk_synth *synth)
> } else {
> for (i = 0; synth_portlist[i]; i++) {
> if (synth_request_region(synth_portlist[i],
> - SYNTH_IO_EXTENT)) {
> + SYNTH_IO_EXTENT)) {
These are not correct. SYNTH_IO_EXTENT should be lines up with the right
side of the ( of the argument list of which it is an element. So the
original code is either correct or close to correct.
julia
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/6] staging: speakup: multiple checkpatch issues Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-09 20:10 +0100
[PATCH 3/6] staging: speakup: spaces preferred around operator Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-09 20:10 +0100
[PATCH 2/6] staging: speakup: Placed Logical on the previous line Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-09 20:10 +0100
[PATCH 1/6] staging: speakup: fix "Alignment match open parenthesis" Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-09 20:10 +0100
[PATCH 6/6] staging: speakup: Add blank line after function/struct/union/enum declarations Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-09 20:10 +0100
[PATCH 5/6] staging: speakup: Alignment should match open parenthesis Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-09 20:10 +0100
Re: [Outreachy kernel] [PATCH 5/6] staging: speakup: Alignment should match open parenthesis Julia Lawall <julia.lawall@lip6.fr> - 2017-03-09 22:40 +0100
[PATCH 4/6] staging: speakup: identation should use tabs Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-09 20:10 +0100
csiph-web