Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1596372

Re: [PATCH 01/19] Coccinelle: locks: identify callers of spin_lock{,_irq,_irqsave}() in irqchip implementations

Show all headers | View raw

> +@match2 depends on match@
> +identifier match.__irq_mask;
> +identifier data;
> +identifier x;
> +identifier l;
> +type T;
> +position j0;
> +expression flags;
> +@@
> +	static void __irq_mask(struct irq_data *data)
> +	{
> +		...
> +		T *x;
> +		...
> +(
> +		spin_lock_irqsave(&x->l@j0, flags);
> +|
> +		spin_lock_irq(&x->l@j0);
> +|
> +		spin_lock(&x->l@j0);
> +)
> +		...
> +	}

I guess that here you want a match if there is a lock anywhere in the
function?  Currently, the rule requires that the lock appear on every
control-flow path.  If you put exists after depends on match in the rule
header, it will match if there exists a control-flow patch that contains a
local call.

Also, ... matches the shortest path between the pattern before the ... and
the pattern after.  Thus, x would have to be the first variable in the
function of pointer type.  To eliminate this constraint, put when any on
each of the ...s.  This will additionally allow more than one lock call in
the function.

All in all, I would suggest the following for this rule:

@match2 depends on match exists@
identifier match.__irq_mask;
identifier data;
identifier x;
identifier l;
type T;
position j0;
expression flags;
@@
	static void __irq_mask(struct irq_data *data)
        {
                ... when any
                T *x;
                ... when any
(
                spin_lock_irqsave(&x->l@j0, flags);
|
                spin_lock_irq(&x->l@j0);
|
                spin_lock(&x->l@j0);
)
                ... when any
        }

julia

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/19] Coccinelle: locks: identify callers of spin_lock{,_irq,_irqsave}() in irqchip implementations Julia Cartwright <julia@ni.com> - 2017-03-09 17:40 +0100
  Re: [PATCH 01/19] Coccinelle: locks: identify callers of  spin_lock{,_irq,_irqsave}() in irqchip implementations Julia Lawall <julia.lawall@lip6.fr> - 2017-03-09 21:20 +0100
    Re: [PATCH 01/19] Coccinelle: locks: identify callers of  spin_lock{,_irq,_irqsave}() in irqchip implementations Julia Cartwright <julia@ni.com> - 2017-03-09 23:50 +0100

csiph-web