Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1596233
| Path | csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.szaf.org!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Taeung Song <treeze.taeung@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 2/7] perf annotate: Avoid division by zero when calculating percent |
| Date | Thu, 09 Mar 2017 18:40:02 +0100 |
| Message-ID | <tjacG-8oc-9@gated-at.bofh.it> (permalink) |
| References | <tjacG-8oc-7@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vGqqv/CPRjafdEBym/BfxlIIEmRXvBbPdoOh0TQGxVg=; b=ZiRG6K1mo6z35mF3I27tLopCuXWuuLASQ/wx37fdK14VnWbX8f1V5U4F6EQUjtYwWF +ecwjIf2uyUdRH0AQe1/fleq55nHtmyOvHSaqsAKGhxLQTTo5eE8qMT4RAodrIovOSvI Vxiv4FcRU//iHwaqA2hc9G+ebBl8ye5+6r16+XydDoy0s2r7mKqyAp1N2Dnulf4WBQwT iztmSBcWf+bpu+SjMKODyYz1q44HEzRyxr8b8YnJWRFWOJQw9kxAh7xhGqH98i9A5hNN dGsdfArYGYYD9Z7i1V87FDDO3cUoP4TPXuqFZekM/OB+XIPqlOz68c6qPgnLzBpbNRtY bdNg== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vGqqv/CPRjafdEBym/BfxlIIEmRXvBbPdoOh0TQGxVg=; b=dlBULWEYIjtOsSbbitTPnmb0Bv4R50KxBZBNqYwGohN3L4dQ3EcvebScJ+GJAfM/80 wPrMHkY6bs2gkfwuAX2v98menMTsKdbup6kn8yxuLsfSq3rX8dXjmev598PMaUjCbt1Y Ffs2UCtUW4c3mcAJ2VcYAzbWqbWMYrixSSQ9/zeuIvhoZE6B7vNGPLkWS4GlQzFxfATd KpPsTzMpx+oVD1aM6aGQp5JQfi5LANPdNjojjqnlptKwfrf5wAA2la9q0lmp4tVFJT74 7QqapKYwHQgfUbRE878utZ7MPXkT5Ix7sgb/6vRbdP/uS1IW4jJjcqG7SvS/TUUc7ZL3 qHbQ== |
| X-Gm-Message-State | AMke39mPgOUDfjViPRhbKT0kfM0zGB0j9VGfbqSZAOgK5tHfjUbOetx+WX6kYrp8xos2ZQ== |
| X-Received | by 10.84.233.206 with SMTP id m14mr18927593pln.153.1489080954203; Thu, 09 Mar 2017 09:35:54 -0800 (PST) |
| X-Mailer | git-send-email 2.7.4 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 88 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>, Masami Hiramatsu <mhiramat@kernel.org>, Taeung Song <treeze.taeung@gmail.com>, Jiri Olsa <jolsa@redhat.com> |
| X-Original-Date | Fri, 10 Mar 2017 02:35:36 +0900 |
| X-Original-Message-ID | <1489080941-3965-3-git-send-email-treeze.taeung@gmail.com> |
| X-Original-References | <1489080941-3965-1-git-send-email-treeze.taeung@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1596233 |
Show key headers only | View raw
Currently perf-annotate with --print-line can print
-nan(0x8000000000000) because of division by zero
when calculating percent.
So if a sum of samples is zero, skip calculating percent.
Before:
$ perf annotate --stdio -l
Sorted summary for file /home/taeung/workspace/a.out
----------------------------------------------
32.89 -nan 7.04 a.c:38
25.14 -nan 0.00 a.c:34
16.26 -nan 56.34 a.c:31
15.88 -nan 1.41 a.c:37
5.67 -nan 0.00 a.c:39
1.13 -nan 35.21 a.c:26
0.95 -nan 0.00 a.c:44
0.57 -nan 0.00 a.c:32
Percent | Source code & Disassembly of a.out for cycles (529 samples)
-----------------------------------------------------------------------------------------
:
...
a.c:26 0.57 -nan 4.23 : 40081a: mov %edi,-0x24(%rbp)
a.c:26 0.00 -nan 9.86 : 40081d: mov %rsi,-0x30(%rbp)
...
After:
$ perf annotate --stdio -l
Sorted summary for file /home/taeung/workspace/a.out
----------------------------------------------
32.89 0.00 7.04 a.c:38
25.14 0.00 0.00 a.c:34
16.26 0.00 56.34 a.c:31
15.88 0.00 1.41 a.c:37
5.67 0.00 0.00 a.c:39
1.13 0.00 35.21 a.c:26
0.95 0.00 0.00 a.c:44
0.57 0.00 0.00 a.c:32
Percent | Source code & Disassembly of old for cycles (529 samples)
-----------------------------------------------------------------------------------------
:
...
a.c:26 0.57 0.00 4.23 : 40081a: mov %edi,-0x24(%rbp)
a.c:26 0.00 0.00 9.86 : 40081d: mov %rsi,-0x30(%rbp)
...
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
tools/perf/util/annotate.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index fc91c6b..9bb43cd 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1665,11 +1665,15 @@ static int symbol__get_source_line(struct symbol *sym, struct map *map,
src_line->nr_pcnt = nr_pcnt;
for (k = 0; k < nr_pcnt; k++) {
+ double percent = 0.0;
+
h = annotation__histogram(notes, evidx + k);
- src_line->samples[k].percent = 100.0 * h->addr[i] / h->sum;
+ if (h->sum)
+ percent = 100.0 * h->addr[i] / h->sum;
- if (src_line->samples[k].percent > percent_max)
- percent_max = src_line->samples[k].percent;
+ if (percent > percent_max)
+ percent_max = percent;
+ src_line->samples[k].percent = percent;
}
if (percent_max <= 0.5)
--
2.7.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH v3 2/7] perf annotate: Avoid division by zero when calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-09 18:40 +0100
csiph-web