memfill v2 now with ARM and x86 implementations

From	Matthew Wilcox <willy@infradead.org>
Newsgroups	linux.kernel
Subject	memfill v2 now with ARM and x86 implementations
Date	2017-03-11 16:00 +0100
Message-ID	<tjQEW-4bK-13@gated-at.bofh.it> (permalink)
References	<t7wLE-AL-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 06, 2017 at 12:16:44AM +0900, Minchan Kim wrote:
> +static inline void zram_fill_page(char *ptr, unsigned long len,
> +					unsigned long value)
> +{
> +	int i;
> +	unsigned long *page = (unsigned long *)ptr;
> +
> +	WARN_ON_ONCE(!IS_ALIGNED(len, sizeof(unsigned long)));
> +
> +	if (likely(value == 0)) {
> +		memset(ptr, 0, len);
> +	} else {
> +		for (i = 0; i < len / sizeof(*page); i++)
> +			page[i] = value;
> +	}
> +}

I've hacked up memset32/memset64 for both ARM and x86 here:

http://git.infradead.org/users/willy/linux-dax.git/shortlog/refs/heads/memfill

Can you do some performance testing and see if it makes a difference?

At this point, I'd probably ask for the first 5 patches in that git
branch to be included, and leave out memfill and the shoddy testsuite.

I haven't actually tested either asm implementation ... only the
C fallback.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

memfill v2 now with ARM and x86 implementations Matthew Wilcox <willy@infradead.org> - 2017-03-11 16:00 +0100
  Re: memfill v2 now with ARM and x86 implementations Minchan Kim <minchan@kernel.org> - 2017-03-13 06:20 +0100

csiph-web