Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1598234

[PATCH RFC] mm/vmscan: donot retry shrink zones when memcg is disabled

Show all headers | View raw

From: Yisheng Xie <xieyisheng1@huawei.com>

When we enter do_try_to_free_pages, the may_thrash is always clear, and
it will retry shrink zones to tap cgroup's reserves memory by setting
may_thrash when the former shrink_zones reclaim nothing.

However, if CONFIG_MEMCG=n, it should not do this useless retry at all,
for we do not have any cgroup's reserves memory to tap, and we have
already done hard work and made no progress.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
---
 mm/vmscan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index bc8031e..b03ccc1 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2808,7 +2808,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
 		return 1;
 
 	/* Untapped cgroup reserves?  Don't OOM, retry. */
-	if (!sc->may_thrash) {
+	if (!sc->may_thrash && IS_ENABLED(CONFIG_MEMCG)) {
 		sc->priority = initial_priority;
 		sc->may_thrash = 1;
 		goto retry;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC] mm/vmscan: donot retry shrink zones when memcg is disabled Yisheng Xie <ysxie@foxmail.com> - 2017-03-11 03:30 +0100
  Re: [PATCH RFC] mm/vmscan: donot retry shrink zones when memcg is disabled Shakeel Butt <shakeelb@google.com> - 2017-03-11 04:50 +0100
    Re: [PATCH RFC] mm/vmscan: donot retry shrink zones when memcg is  disabled Yisheng Xie <ysxie@foxmail.com> - 2017-03-11 11:00 +0100

csiph-web