Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1598199

[PATCH 1/2] x86/xsave: Move xsave initialization to after parsing early parameters

From Andi Kleen <andi@firstfloor.org>
Newsgroups linux.kernel
Subject [PATCH 1/2] x86/xsave: Move xsave initialization to after parsing early parameters
Date 2017-03-11 01:40 +0100
Message-ID <tjDeF-3cL-1@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Andi Kleen <ak@linux.intel.com>

Move the XSAVE initialization code to be after parsing early parameters.
I don't see any reason why the FPU code needs to be initialized that
early, nothing else in the initialization phase uses XSAVE.
This is useful to be able to handle command line parameters in the
XSAVE initialization code.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 arch/x86/kernel/cpu/common.c | 1 -
 arch/x86/kernel/setup.c      | 3 +++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 58094a1f9e9d..db16a28d49a1 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -844,7 +844,6 @@ static void __init early_identify_cpu(struct cpuinfo_x86 *c)
 	}
 
 	setup_force_cpu_cap(X86_FEATURE_ALWAYS);
-	fpu__init_system(c);
 }
 
 void __init early_cpu_init(void)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 4bf0c8926a1c..2a85efc37e1f 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -90,6 +90,7 @@
 #include <asm/processor.h>
 #include <asm/bugs.h>
 #include <asm/kasan.h>
+#include <asm/fpu/internal.h>
 
 #include <asm/vsyscall.h>
 #include <asm/cpu.h>
@@ -987,6 +988,8 @@ void __init setup_arch(char **cmdline_p)
 
 	parse_early_param();
 
+	fpu__init_system(&boot_cpu_data);
+
 #ifdef CONFIG_MEMORY_HOTPLUG
 	/*
 	 * Memory used by the kernel cannot be hot-removed because Linux
-- 
2.9.3

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] x86/xsave: Move xsave initialization to after parsing early parameters Andi Kleen <andi@firstfloor.org> - 2017-03-11 01:40 +0100
  [PATCH 2/2] x86/fpu: Support disabling AVX and AVX512 Andi Kleen <andi@firstfloor.org> - 2017-03-11 01:40 +0100
    Re: [PATCH 2/2] x86/fpu: Support disabling AVX and AVX512 Thomas Gleixner <tglx@linutronix.de> - 2017-03-11 11:50 +0100
      Re: [PATCH 2/2] x86/fpu: Support disabling AVX and AVX512 Andi Kleen <ak@linux.intel.com> - 2017-03-11 18:30 +0100
        Re: [PATCH 2/2] x86/fpu: Support disabling AVX and AVX512 Thomas Gleixner <tglx@linutronix.de> - 2017-03-12 18:40 +0100

csiph-web