RE: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

From	Masaki Ota <masaki.ota@jp.alps.com>
Newsgroups	linux.kernel
Subject	RE: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices
Date	2017-03-08 03:40 +0100
Message-ID	<tizGa-8kP-9@gated-at.bofh.it> (permalink)
References	(4 earlier) <thY3U-6MU-21@gated-at.bofh.it> <thY3U-6MU-19@gated-at.bofh.it> <ticTf-u5-5@gated-at.bofh.it> <tiiYG-4Va-15@gated-at.bofh.it> <tislk-35L-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Dmitry,

OK, I will do it.

Best Regards,
Masaki Ota
-----Original Message-----
From: dmitry.torokhov@gmail.com [mailto:dmitry.torokhov@gmail.com] 
Sent: Wednesday, March 08, 2017 2:58 AM
To: 太田 真喜 Masaki Ota <masaki.ota@jp.alps.com>
Cc: Paul Donohue <linux-kernel@paulsd.com>; Nick Fletcher <nick.m.fletcher@gmail.com>; Joseph Salisbury <joseph.salisbury@canonical.com>; ben@smart-cactus.org; mhocko@suse.com; pali.rohar@gmail.com; rydberg@bitmath.org; linux@roeck-us.net; open list:HID CORE LAYER <linux-input@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org>; stable@vger.kernel.org
Subject: Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

Hi Masaki,

On Tue, Mar 07, 2017 at 08:40:20AM +0000, Masaki Ota wrote:
> Hi, Paul,
> 
> I have modified the source code. 
> 
> There are three issues.
> #1. E7=73 03 28 Button pad device is not assigned "ALPS_BUTTONPAD" Flag correctly.
> #2. E7=73 03 28 devices are not assigned " ALPS_DUALPOINT" Flag correctly.
> #3. E7=73 03 28 device cursor speed is slow.
> 
> Actually, the cause is all the same.
> E7=73 03 28 device does not get correct information from OTP.
> OTP is the device information byte. I specified correct bit.
> 
> Then, I think it is also the issue.
> #4. Stick Pointer cursor speed is fast.
> 
> I will check Stick parameter.

Could you please submit this as a proper patch now that we have confirmation that it works? Also, I wonder if V8PLUS should be full protocol instead of a flag.

Thanks.

--
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74  03 28 devices Joseph Salisbury <joseph.salisbury@canonical.com> - 2017-03-03 21:00 +0100
  Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag  for 74 03 28 devices Paul Donohue <linux-kernel@paulsd.com> - 2017-03-05 19:00 +0100
    RE: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag  for 74 03 28 devices Masaki Ota <masaki.ota@jp.alps.com> - 2017-03-06 11:30 +0100
      Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag  for 74 03 28 devices "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com> - 2017-03-06 21:10 +0100
      Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag  for 74 03 28 devices Paul Donohue <linux-kernel@paulsd.com> - 2017-03-07 03:20 +0100
        Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag  for 74 03 28 devices "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com> - 2017-03-07 19:50 +0100
          RE: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag  for 74 03 28 devices Masaki Ota <masaki.ota@jp.alps.com> - 2017-03-08 03:40 +0100

csiph-web