Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594806

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

Show all headers | View raw

Hi Colin,

Thank you for your comment.
It is a bug, will be fixed in the next patch.

On 3/7/2017 22:30, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The are only HIST_ENTRIES worth of entries in  hist_entry however the
> for-loop is iterating one too many times leasing to a read access off
> the end off the array ctrls->hist_entry.  Fix this by iterating by
> the correct number of times.
>
> Detected by CoverityScan, CID#1415279 ("Out-of-bounds read")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/media/platform/atmel/atmel-isc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c
> index b380a7d..7dacf8c 100644
> --- a/drivers/media/platform/atmel/atmel-isc.c
> +++ b/drivers/media/platform/atmel/atmel-isc.c
> @@ -1298,7 +1298,7 @@ static void isc_hist_count(struct isc_device *isc)
>  	regmap_bulk_read(regmap, ISC_HIS_ENTRY, hist_entry, HIST_ENTRIES);
>
>  	*hist_count = 0;
> -	for (i = 0; i <= HIST_ENTRIES; i++)
> +	for (i = 0; i < HIST_ENTRIES; i++)
>  		*hist_count += i * (*hist_entry++);
>  }
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue Colin King <colin.king@canonical.com> - 2017-03-07 16:00 +0100
  Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of  bounds read issue "Wu, Songjun" <Songjun.Wu@microchip.com> - 2017-03-08 03:40 +0100
    Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of  bounds read issue Hans Verkuil <hverkuil@xs4all.nl> - 2017-03-09 12:00 +0100
      Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of  bounds read issue Colin Ian King <colin.king@canonical.com> - 2017-03-09 13:00 +0100
        Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of  bounds read issue "Wu, Songjun" <Songjun.Wu@microchip.com> - 2017-03-13 03:20 +0100
      Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out  of bounds read issue walter harms <wharms@bfs.de> - 2017-03-09 13:00 +0100
      Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of  bounds read issue "Wu, Songjun" <Songjun.Wu@microchip.com> - 2017-03-13 07:00 +0100
        Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of  bounds read issue Hans Verkuil <hverkuil@xs4all.nl> - 2017-03-13 10:30 +0100
          Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of  bounds read issue "Wu, Songjun" <Songjun.Wu@microchip.com> - 2017-03-13 10:40 +0100
            Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of  bounds read issue Hans Verkuil <hverkuil@xs4all.nl> - 2017-03-13 11:30 +0100

csiph-web