Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594634

Re: [PATCH V3] ARM: dts: exynos5440: support the phy-pcie node for pcie

Show all headers | View raw

On Tue, Feb 28, 2017 at 04:00:26PM +0900, Jaehoon Chung wrote:
> Add pcie-phy node for using phy-exynos-pcie.
> 
> There are some modifications.
> 1. Remove the configuration space values in "ranges" property.
> - The getting configuration space from ranges is old way.
> - Instead, It can be got from "config"
> 
> 2. Use the reg-names as "elbi", "config".
> - Can know the purpose of use with reg-names.
> 

Thanks, applied with changes:
1. Proper subject prefix. Please pay attention to that.
2. Re-write of commit message. There were language errors, mixed up
   prepositions. Also a "phy-pcie node" cannot be "supported". You can
   add a node. You cannot support a node.

The quality of commit message is important for maintainability of source
code because eventually it explains the logic behind the changes in the
code.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH V3] ARM: dts: exynos5440: support the phy-pcie node for  pcie Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-07 21:50 +0100

csiph-web