Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594664

[PATCH RT 06/10] sched/rt: Add a missing rescheduling point

Show all headers | View raw

4.4.50-rt63-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Since the change in commit:

  fd7a4bed1835 ("sched, rt: Convert switched_{from, to}_rt() / prio_changed_rt() to balance callbacks")

... we don't reschedule a task under certain circumstances:

Lets say task-A, SCHED_OTHER, is running on CPU0 (and it may run only on
CPU0) and holds a PI lock. This task is removed from the CPU because it
used up its time slice and another SCHED_OTHER task is running. Task-B on
CPU1 runs at RT priority and asks for the lock owned by task-A. This
results in a priority boost for task-A. Task-B goes to sleep until the
lock has been made available. Task-A is already runnable (but not active),
so it receives no wake up.

The reality now is that task-A gets on the CPU once the scheduler decides
to remove the current task despite the fact that a high priority task is
enqueued and waiting. This may take a long time.

The desired behaviour is that CPU0 immediately reschedules after the
priority boost which made task-A the task with the lowest priority.

Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Fixes: fd7a4bed1835 ("sched, rt: Convert switched_{from, to}_rt() prio_changed_rt() to balance callbacks")
Link: http://lkml.kernel.org/r/20170124144006.29821-1-bigeasy@linutronix.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/deadline.c | 3 +--
 kernel/sched/rt.c       | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 7a72e69fcf65..20e0c9b9ace5 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1772,12 +1772,11 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p)
 #ifdef CONFIG_SMP
 		if (tsk_nr_cpus_allowed(p) > 1 && rq->dl.overloaded)
 			queue_push_tasks(rq);
-#else
+#endif
 		if (dl_task(rq->curr))
 			check_preempt_curr_dl(rq, p, 0);
 		else
 			resched_curr(rq);
-#endif
 	}
 }
 
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 8cf360d309ec..4ac6937f4a65 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2138,10 +2138,9 @@ static void switched_to_rt(struct rq *rq, struct task_struct *p)
 #ifdef CONFIG_SMP
 		if (tsk_nr_cpus_allowed(p) > 1 && rq->rt.overloaded)
 			queue_push_tasks(rq);
-#else
+#endif /* CONFIG_SMP */
 		if (p->prio < rq->curr->prio)
 			resched_curr(rq);
-#endif /* CONFIG_SMP */
 	}
 }
 
-- 
2.10.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RT 00/10] Linux 4.4.50-rt63-rc1 Steven Rostedt <rostedt@goodmis.org> - 2017-03-07 22:30 +0100
  [PATCH RT 02/10] radix-tree: use local locks Steven Rostedt <rostedt@goodmis.org> - 2017-03-07 22:30 +0100
  [PATCH RT 05/10] rt: Drop mutex_disable() on !DEBUG configs and the GPL suffix from  export symbol Steven Rostedt <rostedt@goodmis.org> - 2017-03-07 22:30 +0100
  [PATCH RT 08/10] rt: Drop the removal of _GPL from rt_mutex_destroy()s EXPORT_SYMBOL Steven Rostedt <rostedt@goodmis.org> - 2017-03-07 22:30 +0100
  [PATCH RT 10/10] Linux 4.4.50-rt63-rc1 Steven Rostedt <rostedt@goodmis.org> - 2017-03-07 22:30 +0100
  [PATCH RT 06/10] sched/rt: Add a missing rescheduling point Steven Rostedt <rostedt@goodmis.org> - 2017-03-07 22:30 +0100
  [PATCH RT 07/10] lockdep: Handle statically initialized PER_CPU locks proper Steven Rostedt <rostedt@goodmis.org> - 2017-03-07 22:30 +0100
  [PATCH RT 09/10] lockdep: Fix compilation error for !CONFIG_MODULES and !CONFIG_SMP Steven Rostedt <rostedt@goodmis.org> - 2017-03-07 22:30 +0100
  [PATCH RT 03/10] pinctrl: qcom: Use raw spinlock variants Steven Rostedt <rostedt@goodmis.org> - 2017-03-07 22:30 +0100
  [PATCH RT 01/10] cpuset: Convert callback_lock to raw_spinlock_t Steven Rostedt <rostedt@goodmis.org> - 2017-03-07 22:30 +0100

csiph-web