Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594520

Re: [PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly

Show all headers | View raw

On Tue, Mar 07, 2017 at 03:10:20PM +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
> 
> __vmalloc* allows users to provide gfp flags for the underlying
> allocation. This API is quite popular
> $ git grep "=[[:space:]]__vmalloc\|return[[:space:]]*__vmalloc" | wc -l
> 77
> 
> the only problem is that many people are not aware that they really want
> to give __GFP_HIGHMEM along with other flags because there is really no
> reason to consume precious lowmemory on CONFIG_HIGHMEM systems for pages
> which are mapped to the kernel vmalloc space. About half of users don't
> use this flag, though. This signals that we make the API unnecessarily
> too complex.
> 
> This patch simply uses __GFP_HIGHMEM implicitly when allocating pages to
> be mapped to the vmalloc space. Current users which add __GFP_HIGHMEM
> are simplified and drop the flag.
> 
> Signed-off-by: Michal Hocko <mhocko@suse.com>

Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly Michal Hocko <mhocko@kernel.org> - 2017-03-07 15:20 +0100
  Re: [PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly Matthew Wilcox <willy@infradead.org> - 2017-03-07 19:50 +0100
    Re: [PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly Matthew Wilcox <willy@infradead.org> - 2017-03-07 21:00 +0100
      Re: [PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly Vlastimil Babka <vbabka@suse.cz> - 2017-03-08 08:40 +0100
      Re: [PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly Michal Hocko <mhocko@kernel.org> - 2017-03-08 14:10 +0100
  Re: [PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly Andrew Morton <akpm@linux-foundation.org> - 2017-03-08 00:20 +0100
    Re: [PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly Matthew Wilcox <willy@infradead.org> - 2017-03-08 01:20 +0100
    Re: [PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly Michal Hocko <mhocko@kernel.org> - 2017-03-08 11:50 +0100
  Re: [PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly Vlastimil Babka <vbabka@suse.cz> - 2017-03-08 11:40 +0100
    Re: [PATCH] mm, vmalloc: use __GFP_HIGHMEM implicitly Michal Hocko <mhocko@kernel.org> - 2017-03-08 11:50 +0100

csiph-web