Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594397

Re: [PATCH v10 2/2] media: i2c: Add support for OV5647 sensor.

Show all headers | View raw

Hi Ramiro,

On Mon, Mar 06, 2017 at 11:16:34AM +0000, Ramiro Oliveira wrote:
...
> +static int __sensor_init(struct v4l2_subdev *sd)
> +{
> +	int ret;
> +	u8 resetval, rdval;
> +	struct i2c_client *client = v4l2_get_subdevdata(sd);
> +
> +	dev_dbg(&client->dev, "sensor init\n");

This looks like a debugging time leftover. Please remove.

With that,

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

...

> +static int ov5647_parse_dt(struct device_node *np)
> +{
> +	struct v4l2_of_endpoint bus_cfg;
> +	struct device_node *ep;
> +
> +	int ret;
> +
> +	ep = of_graph_get_next_endpoint(np, NULL);
> +	if (!ep)
> +		return -EINVAL;
> +
> +	ret = v4l2_of_parse_endpoint(ep, &bus_cfg);
> +
> +	of_node_put(ep);
> +	return ret;
> +}

This will conflict with my fwnode patchset. Let's see in which order the
patches will be merged, one of the sets has to be changed. The work is
trivial though.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v10 0/2] Add support for Omnivision OV5647 Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2017-03-06 12:30 +0100
  [PATCH v10 2/2] media: i2c: Add support for OV5647 sensor. Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2017-03-06 12:30 +0100
    Re: [PATCH v10 2/2] media: i2c: Add support for OV5647 sensor. Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-07 17:20 +0100
  [PATCH v10 1/2] Documentation: DT: Add OV5647 bindings Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2017-03-06 12:30 +0100

csiph-web