Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1594358

[PATCH 13/23] perf kvm: Add -q/--quiet option

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From Namhyung Kim <namhyung@kernel.org>
Newsgroups linux.kernel
Subject [PATCH 13/23] perf kvm: Add -q/--quiet option
Date Tue, 07 Mar 2017 16:40:02 +0100
Message-ID <tipns-152-9@gated-at.bofh.it> (permalink)
References <tip46-X4-13@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=YBWnD1h4DJxKX4+TIj0+A8oFn43B6mpT8hLidFAdq7c=; b=Et5G7wJyLRs6hW1V4zccrZpftm919kp95hk9ixaN7O1H6C6u0Y595gTRJVRKX2kVhB SPPlQR4o4QGdEUknQLQVMOxO3qfO1DPHzQ0oeL1LMuFjnL08dw1xoiFM7AVOplnAnJV1 M4Ck5wkOi/TuaJ6ImqDsaZJirKT3ZdyyJs2wsY/VeacEr4OPez8FTjT0Lq13XffoFjlD 3kVVty1kfGbZJywStkn+8EnkoSxE4H1m62ijxNGV1CLCVdysDsra2oGiZL5Ym6/JAf3Z Mn8IdxWBeIm5qWAQ6pkbaT2WJ18XRX9DzK+/z3rkUNBFDdAR0IX79kG39aucagApTZmd wP5g==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=YBWnD1h4DJxKX4+TIj0+A8oFn43B6mpT8hLidFAdq7c=; b=tTkoqOhPGHK3V7idHDRG3UMDg5RAzk8UQRw5aYwNIvQQn95wLrKYL91CIgu2bRFrSm v6JL869/dSxw3TnDTseutxwOUlzUFLBnlJr9jo/5sLQN0+ZP1/J6BXC+pflktiWxlYUA E2JVC3cs4M+ZNWfiiDHtvzW5blHdaZ/+D7jrVt9DPafIcax7DFR5crGDLzQnhTKBunON oPNOsf4QCWmHLmhl/EzdlA58ZZze5ZtqUun3amgA5cAnD2qkW3ttGD+wm7kLtRI76qsI bKQxrSOUg/jyFNsfCI1tCTsa8BYIyIjh8f9IlrFR8jbDQeoXlGDrdUhuW/Op+S6IlJvI 9+DA==
X-Gm-Message-State AMke39nPs9r/pY40YvhvknA5RZMdrcEMoenX+QELUmweC7qx8LPrdZU4whNrPb4ejA5OsQ==
X-Received by 10.99.115.12 with SMTP id o12mr871386pgc.165.1488899391447; Tue, 07 Mar 2017 07:09:51 -0800 (PST)
X-Mailer git-send-email 2.11.0
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 75
Organization linux.* mail to news gateway
X-Original-Cc Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>, kernel-team@lge.com
X-Original-Date Wed, 8 Mar 2017 00:08:41 +0900
X-Original-Message-ID <20170307150851.22304-14-namhyung@kernel.org>
X-Original-References <20170307150851.22304-1-namhyung@kernel.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1594358

Show key headers only | View raw


The -q/--quiet option is to suppress any message.  Sometimes users just
want to run the command and it can be used for that case.

Suggested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/Documentation/perf-kvm.txt |  3 +++
 tools/perf/builtin-kvm.c              | 10 +++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-kvm.txt b/tools/perf/Documentation/perf-kvm.txt
index 6a5bb2b17039..8eec9d13181c 100644
--- a/tools/perf/Documentation/perf-kvm.txt
+++ b/tools/perf/Documentation/perf-kvm.txt
@@ -96,6 +96,9 @@ OPTIONS
 -v::
 --verbose::
 	Be more verbose (show counter open errors, etc).
+-q::
+--quiet::
+	Do not show any message.
 
 STAT REPORT OPTIONS
 -------------------
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 08fa88f62a24..1d121bb0a14d 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -1018,7 +1018,7 @@ static int kvm_live_open_events(struct perf_kvm_stat *kvm)
 
 	err = perf_evlist__open(evlist);
 	if (err < 0) {
-		printf("Couldn't create the events: %s\n",
+		pr_err("Couldn't create the events: %s\n",
 		       str_error_r(errno, sbuf, sizeof(sbuf)));
 		goto out;
 	}
@@ -1313,6 +1313,7 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
 			perf_evlist__parse_mmap_pages),
 		OPT_INCR('v', "verbose", &verbose,
 			"be more verbose (show counter open errors, etc)"),
+		OPT_BOOLEAN('q', "quiet", &quiet, "Do not show any message"),
 		OPT_BOOLEAN('a', "all-cpus", &kvm->opts.target.system_wide,
 			"system-wide collection from all CPUs"),
 		OPT_UINTEGER('d', "display", &kvm->display_time,
@@ -1372,6 +1373,9 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
 			usage_with_options(live_usage, live_options);
 	}
 
+	if (quiet)
+		perf_quiet_option();
+
 	kvm->duration *= NSEC_PER_USEC;   /* convert usec to nsec */
 
 	/*
@@ -1557,6 +1561,7 @@ int cmd_kvm(int argc, const char **argv, const char *prefix __maybe_unused)
 			   "file", "file saving guest os /proc/modules"),
 		OPT_INCR('v', "verbose", &verbose,
 			    "be more verbose (show counter open errors, etc)"),
+		OPT_BOOLEAN('q', "quiet", &quiet, "Do not show any message"),
 		OPT_END()
 	};
 
@@ -1572,6 +1577,9 @@ int cmd_kvm(int argc, const char **argv, const char *prefix __maybe_unused)
 	if (!argc)
 		usage_with_options(kvm_usage, kvm_options);
 
+	if (quiet)
+		perf_quiet_option();
+
 	if (!perf_host)
 		perf_guest = 1;
 
-- 
2.11.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 13/23] perf kvm: Add -q/--quiet option Namhyung Kim <namhyung@kernel.org> - 2017-03-07 16:40 +0100

csiph-web