Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594272

Re: [PATCH 2/3] ASoC: dio2125: add dio2125 amp driver

Show key headers only | View raw

On Tue, 2017-03-07 at 13:36 +0100, Mark Brown wrote:
> On Mon, Mar 06, 2017 at 06:44:50PM +0100, Jerome Brunet wrote:
> 
> > +	gpiod_set_value(priv->gpiod_enable, val);
> 
> You should use gpiod_set_value_cansleep() so that the driver can work
> with all GPIOs unless there's a specific need to have GPIOs you can
> control in interrupt (which should be the case for anything you're
> using
> for DAPM control).

Indeed, Thanks for pointing this out.
I have question regarding this DAPM control.
Here, I put the control in DAPM so it can help with the pop noise
reduction, but I think it would be nice if the user could force the
mute if he wants to.

Would it be OK to add a user control and some logic so the output is
enabled only if DAPM and the user agree it should ?

> 
> Please submit an incremental patch fixing this.

Done

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] ASoC: dio2125: add dio2125 amp driver Jerome Brunet <jbrunet@baylibre.com> - 2017-03-06 19:20 +0100
  Applied "ASoC: dio2125: add dio2125 amp driver" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-03-07 14:00 +0100
  Re: [PATCH 2/3] ASoC: dio2125: add dio2125 amp driver Mark Brown <broonie@kernel.org> - 2017-03-07 14:30 +0100
    Re: [PATCH 2/3] ASoC: dio2125: add dio2125 amp driver Mark Brown <broonie@kernel.org> - 2017-03-07 15:00 +0100
    Re: [PATCH 2/3] ASoC: dio2125: add dio2125 amp driver Jerome Brunet <jbrunet@baylibre.com> - 2017-03-07 15:30 +0100
      Re: [alsa-devel] [PATCH 2/3] ASoC: dio2125: add dio2125 amp driver Lars-Peter Clausen <lars@metafoo.de> - 2017-03-07 15:50 +0100

csiph-web