Re: [PATCH] objtool: drop redundant flags generation

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.albasani.net!tahina.priv.at!bofh.it!news.nic.it!robomod
From	Masami Hiramatsu <mhiramat@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] objtool: drop redundant flags generation
Date	Tue, 07 Mar 2017 15:00:02 +0100
Message-ID	<tinOG-8fM-13@gated-at.bofh.it> (permalink)
References	<ti4Cm-2Wx-15@gated-at.bofh.it> <ti4Cm-2Wx-13@gated-at.bofh.it> <ti5RM-3Nc-23@gated-at.bofh.it> <ti8FY-5Os-11@gated-at.bofh.it> <tiiFk-4KU-17@gated-at.bofh.it>
X-Original-To	Nicholas Mc Guire <der.herr@hofr.at>
X-Mailer	Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	Josh Poimboeuf <jpoimboe@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, Masami Hiramatsu <mhiramat@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, Arnaldo Carvalho de Melo <acme@redhat.com>, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 7 Mar 2017 14:55:21 +0100
X-Original-Message-ID	<20170307145521.887324964e1e468822dba0a3@kernel.org>
X-Original-References	<1488819625-27395-1-git-send-email-der.herr@hofr.at> <20170306172537.uox2f7ru3x72jzea@treble> <20170306175401.GA26026@osadl.at> <20170306214054.tobodci764xvbwr7@treble> <20170307081319.GA31027@osadl.at>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1594247

Show key headers only | View raw

On Tue, 7 Mar 2017 08:13:19 +0000
Nicholas Mc Guire <der.herr@hofr.at> wrote:

> On Mon, Mar 06, 2017 at 03:40:54PM -0600, Josh Poimboeuf wrote:
> > On Mon, Mar 06, 2017 at 05:54:01PM +0000, Nicholas Mc Guire wrote:
> > > On Mon, Mar 06, 2017 at 11:25:37AM -0600, Josh Poimboeuf wrote:
> > > > >  arch/x86/tools/gen-insn-attr-x86.awk              | 12 ++++++++++--
> > > > >  tools/objtool/arch/x86/insn/gen-insn-attr-x86.awk | 12 ++++++++++--
> > > > 
> > > > There's actually a third copy of the decoder in:
> > > > 
> > > >   tools/perf/util/intel-pt-decoder/
> > > > 
> > > > Yes, the duplication is a pain, but it's part of an effort to keep
> > > > 'tools/*' source independent from kernel code.
> > > > 
> > > > Maybe we can at least combine the objtool and perf versions someday.
> > > >
> > > Bad - missed that one - did not build perf - the generator seems to
> > > be the same though only differing by a single blank line - so pulling 
> > > those together should be a non-issue atleast with respect to the 
> > > generator as the x86-opcode-map.txt are all the same ? ...or what 
> > > fun am I missing ?
> > 
> > In theory, all three copies of the decoder should be identical.  That
> > includes all the files: insn.[ch], inat.[ch], inat_types.h,
> > gen-insn-attr-x86.awk, x86-opcode-map.txt.
> >
> Understood - but this is a different problem that is being
> addressed with this cleanup - the duplicates make no sense in
> any case as far as I can see - with or without consolidation of
> the other files (and x86-opcode-map.txt does seem to be the
> same in all 3 cases) - the point was that it is causing a quite
> large number of coccicheck warnings which are iritating and
> in this case easy to remove.

Why would you apply coccinelle to auto-generated code?
I recommend you to change coccicheck to avoid checking
auto-generated code first.

Thank you,


-- 
Masami Hiramatsu <mhiramat@kernel.org>

Thread

Re: [PATCH] objtool: drop redundant flags generation Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-06 18:30 +0100
  Re: [PATCH] objtool: drop redundant flags generation Nicholas Mc Guire <der.herr@hofr.at> - 2017-03-06 19:50 +0100
    Re: [PATCH] objtool: drop redundant flags generation Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-06 22:50 +0100
      Re: [PATCH] objtool: drop redundant flags generation Nicholas Mc Guire <der.herr@hofr.at> - 2017-03-07 09:30 +0100
        Re: [PATCH] objtool: drop redundant flags generation Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-07 15:00 +0100
          Re: [PATCH] objtool: drop redundant flags generation Nicholas Mc Guire <der.herr@hofr.at> - 2017-03-07 15:50 +0100

csiph-web