Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594188

RE: [PATCH] staging: unisys: fix sparse warnings

Show all headers | View raw

> -----Original Message-----
> From: Andrea Ghittino [mailto:aghittino@gmail.com]
> Sent: Saturday, March 4, 2017 12:21 PM
> To: devel@driverdev.osuosl.org; Kershner, David A
> <David.Kershner@unisys.com>; gregkh@linuxfoundation.org; *S-Par-
> Maintainer <SParMaintainer@unisys.com>; linux-kernel@vger.kernel.org
> Subject: [PATCH] staging: unisys: fix sparse warnings
> 
> Sparse generates two warnings related to incorrect type in assignment.
> This patch changes the types in the struct defined in unisys
> 
> Signed-off-by: Andrea Ghittino <aghittino@gmail.com>

Acked-by: David Kershner <david.kershner@unisys.com>

Tested it on s-Par and no problems. 

> ---
> Compile tested only
> 
>  iochannel.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/unisys/include/iochannel.h
> b/drivers/staging/unisys/include/iochannel.h
> index 54f4900..41e5b4e 100644
> --- a/drivers/staging/unisys/include/iochannel.h
> +++ b/drivers/staging/unisys/include/iochannel.h
> @@ -308,8 +308,8 @@ struct net_pkt_xmt {
>  		u8 valid;	/* 1 = struct is valid - else ignore */
>  		u8 hrawoffv;	/* 1 = hwrafoff is valid */
>  		u8 nhrawoffv;	/* 1 = nhwrafoff is valid */
> -		u16 protocol;	/* specifies packet protocol */
> -		u32 csum;	/* value used to set skb->csum at IOPart */
> +		__be16 protocol;	/* specifies packet protocol */
> +		__wsum csum;	/* value used to set skb->csum at IOPart */
>  		u32 hrawoff;	/* value used to set skb->h.raw at IOPart */
>  		/* hrawoff points to the start of the TRANSPORT LAYER
> HEADER */
>  		u32 nhrawoff;	/* value used to set skb->nh.raw at IOPart */

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: unisys: fix sparse warnings Andrea Ghittino <aghittino@gmail.com> - 2017-03-04 18:30 +0100
  RE: [PATCH] staging: unisys: fix sparse warnings "Kershner, David A" <David.Kershner@unisys.com> - 2017-03-07 13:50 +0100
  Re: [PATCH] staging: unisys: fix sparse warnings Andrea Ghittino <aghittino@gmail.com> - 2017-03-07 22:50 +0100
  Re: [PATCH] staging: unisys: fix sparse warnings Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 23:00 +0100

csiph-web