Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1594106
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] x86/head_64.S: Rename start_cpu() |
| Date | 2017-03-07 12:00 +0100 |
| Message-ID | <til0t-6mK-3@gated-at.bofh.it> (permalink) |
| References | <theDL-7cX-5@gated-at.bofh.it> <tiji2-5io-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Mar 07, 2017 at 10:06:38AM +0100, Ingo Molnar wrote:
> The local labels syntax is silly, I always end up looking twice to make sense of
> 'Ljump' or 'Lwhatever' ;-)
>
> We cannot do anything about that - but we can name our symbols to work it around.
> But the price is the extra underscore in the symbol name...
Sure, but other labels in this file don't have the preceding "_".
Perhaps we should agree on a convention for the local labels naming in
our asm and adhere to it...
Hmm.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] x86/head_64.S: Rename start_cpu() Borislav Petkov <bp@alien8.de> - 2017-03-04 11:00 +0100
[PATCH 2/2] x86/head_64.S: Pass struct boot_params' virtual address to C Borislav Petkov <bp@alien8.de> - 2017-03-04 11:00 +0100
Re: [PATCH 2/2] x86/head_64.S: Pass struct boot_params' virtual address to C Ingo Molnar <mingo@kernel.org> - 2017-03-07 10:20 +0100
Re: [PATCH 2/2] x86/head_64.S: Pass struct boot_params' virtual address to C Borislav Petkov <bp@alien8.de> - 2017-03-07 12:00 +0100
Re: [PATCH 1/2] x86/head_64.S: Rename start_cpu() Ingo Molnar <mingo@kernel.org> - 2017-03-07 10:10 +0100
Re: [PATCH 1/2] x86/head_64.S: Rename start_cpu() Borislav Petkov <bp@alien8.de> - 2017-03-07 12:00 +0100
Re: [PATCH 1/2] x86/head_64.S: Rename start_cpu() Ingo Molnar <mingo@kernel.org> - 2017-03-07 16:00 +0100
[tip:x86/boot] x86/boot/64: Rename start_cpu() tip-bot for Borislav Petkov <tipbot@zytor.com> - 2017-03-07 14:10 +0100
csiph-web