Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594109

Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel

Show all headers | View raw

On 2017/03/06 10:06PM, Masami Hiramatsu wrote:
> On Mon,  6 Mar 2017 23:19:09 +0530
> "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> 
> > Masami,
> > Your patch works, thanks! However, I felt we could refactor and reuse
> > some of the code across kprobes.c for this purpose. Can you please see
> > if the below patch is fine?
> 
> OK, looks good to me:)
> 
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks for the review, Masami!
I ended up adding one more patch to this series (patch 5/6) to move the
ftrace README scanning out of probe-file.c, as it doesn't need libelf.
Patch 6 fails to build without libelf otherwise. Please take a look.

Arnaldo,
I am re-sending the remaining patches in this series which apply on top
of the 4 patches you sent to Ingo, so as to keep this simple. All the
patches have been acked, except the new patch 5/6. Kindly take a look.

Thanks,
Naveen

--
Naveen N. Rao (6):
  trace/kprobes: fix check for kretprobe offset within function entry
  powerpc: kretprobes: override default function entry offset
  perf: probe: factor out the ftrace README scanning
  perf: kretprobes: offset from reloc_sym if kernel supports it
  perf: probes: move ftrace README parsing logic into
    trace-event-parse.c
  perf: powerpc: choose local entry point with kretprobes

 arch/powerpc/kernel/kprobes.c               |  9 +++
 include/linux/kprobes.h                     |  1 +
 kernel/kprobes.c                            | 40 ++++++++-----
 kernel/trace/trace_kprobe.c                 |  2 +-
 tools/perf/arch/powerpc/util/sym-handling.c | 10 ++--
 tools/perf/util/probe-event.c               | 12 ++--
 tools/perf/util/probe-file.c                | 80 +++-----------------------
 tools/perf/util/probe-file.h                |  1 -
 tools/perf/util/trace-event-parse.c         | 89 +++++++++++++++++++++++++++++
 tools/perf/util/trace-event.h               |  4 ++
 10 files changed, 149 insertions(+), 99 deletions(-)

-- 
2.11.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-03 00:10 +0100
  Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if  kernel supports it Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-04 02:00 +0100
    Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if  kernel supports it Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-04 03:50 +0100
      Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if  kernel supports it Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-04 03:50 +0100
      Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if  kernel supports it Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-04 05:50 +0100
        Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel  supports it "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-06 20:10 +0100
        Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if  kernel supports it Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-06 22:10 +0100
          Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-07 12:00 +0100
            [RESEND PATCH 6/6] perf: powerpc: choose local entry point with kretprobes "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-07 12:00 +0100
              [PATCH v2 6/6] perf: powerpc: choose local entry point with kretprobes "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-07 22:00 +0100
            [RESEND PATCH 2/6] powerpc: kretprobes: override default function entry offset "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-07 12:00 +0100
            [PATCH 5/6] perf: probes: move ftrace README parsing logic into trace-event-parse.c "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-07 12:00 +0100
              Re: [PATCH 5/6] perf: probes: move ftrace README parsing logic into  trace-event-parse.c Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-07 17:00 +0100
                Re: [PATCH 5/6] perf: probes: move ftrace README parsing logic into  trace-event-parse.c "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-07 20:50 +0100
              Re: [PATCH 5/6] perf: probes: move ftrace README parsing logic into  trace-event-parse.c "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-07 17:40 +0100
              Re: [PATCH 5/6] perf: probes: move ftrace README parsing logic into  trace-event-parse.c Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-07 18:50 +0100
        Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel supports it "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-07 01:50 +0100
    Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if kernel  supports it "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-06 16:10 +0100
      Re: [PATCH v4 2/3] perf: kretprobes: offset from reloc_sym if  kernel supports it Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-06 22:30 +0100

csiph-web