Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594032

Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes

Show all headers | View raw

* James Hogan <james.hogan@imgtec.com> wrote:

> Hi Guenter,
> 
> On Mon, Mar 06, 2017 at 11:13:55AM -0800, Guenter Roeck wrote:
> > Since commit f3ac60671954 ("sched/headers: Move task-stack related
> > APIs from <linux/sched.h> to <linux/sched/task_stack.h>") and commit
> > f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from
> > <linux/sched.h>"), various mips builds fail as follows.
> > 
> > arch/mips/kernel/smp-mt.c: In function ‘vsmp_boot_secondary’:
> > arch/mips/include/asm/processor.h:384:41: error:
> > 	implicit declaration of function ‘task_stack_page’
> > 
> > In file included from
> > 	/opt/buildbot/slave/hwmon-testing/build/arch/mips/kernel/pm.c:
> > arch/mips/include/asm/fpu.h: In function '__own_fpu':
> > arch/mips/include/asm/processor.h:385:31: error:
> > 	invalid application of 'sizeof' to incomplete type 'struct pt_regs'
> 
> This one is in an inline function, so I think it'd affect multiple
> includes of <asm/fpu.h> even if __own_fpu isn't used, so I think the
> following patch which adds the include ptrace.h in fpu.h is more robust
> than adding to the individual c files affected:
> https://patchwork.linux-mips.org/patch/15386/
> 
> Admitedly it could probably have a more specific subject line since
> there are more similar errors.

Just a quick question: is your MIPS build fix going to be merged and sent to 
Linus? I can apply it too, and send it to Linus later today, together with a few 
other sched.h header related build fixes.

Assuming it's all properly tested - my limited MIPS defconfig builds worked fine - 
but MIPS has a lot of build variations.

Either way is fine to me.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] MIPS: Fix build breakage caused by header file changes Guenter Roeck <linux@roeck-us.net> - 2017-03-06 21:10 +0100
  Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes James Hogan <james.hogan@imgtec.com> - 2017-03-07 00:50 +0100
    Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes Guenter Roeck <linux@roeck-us.net> - 2017-03-07 04:40 +0100
      Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes James Hogan <james.hogan@imgtec.com> - 2017-03-07 11:10 +0100
        Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes James Hogan <james.hogan@imgtec.com> - 2017-03-07 11:40 +0100
    Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes Ingo Molnar <mingo@kernel.org> - 2017-03-07 10:30 +0100
      Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes James Hogan <james.hogan@imgtec.com> - 2017-03-07 11:10 +0100
        Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes Ingo Molnar <mingo@kernel.org> - 2017-03-07 11:40 +0100

csiph-web