Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1595298

Re: [PATCH 3/6] mm/migrate: Add copy_pages_mthread function

From Anshuman Khandual <khandual@linux.vnet.ibm.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/6] mm/migrate: Add copy_pages_mthread function
Date 2017-03-08 16:50 +0100
Message-ID <tiM0F-86-1@gated-at.bofh.it> (permalink)
References <tbPZn-4hF-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 02/17/2017 05:57 PM, kbuild test robot wrote:
> Hi Zi,
> 
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.10-rc8 next-20170216]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Anshuman-Khandual/Enable-parallel-page-migration/20170217-200523
> config: i386-tinyconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All warnings (new ones prefixed by >>):
> 
>    mm/copy_pages_mthread.c: In function 'copy_pages_mthread':
>>> mm/copy_pages_mthread.c:49:10: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>      cpumask = cpumask_of_node(node);

My bad. This fixes the above warning. Will fix it up next time
around.

diff --git a/mm/copy_pages_mthread.c b/mm/copy_pages_mthread.c
index 9ad2ef6..46b22b1 100644
--- a/mm/copy_pages_mthread.c
+++ b/mm/copy_pages_mthread.c
@@ -46,7 +46,7 @@ int copy_pages_mthread(struct page *to, struct page
*from, int nr_pages)
        int cpu_id_list[32] = {0};

        node = page_to_nid(to);
-       cpumask = cpumask_of_node(node);
+       cpumask = (struct cpumask *) cpumask_of_node(node);
        cthreads = nr_copythreads;
        cthreads = min_t(unsigned int, cthreads, cpumask_weight(cpumask));
        cthreads = (cthreads / 2) * 2;

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 3/6] mm/migrate: Add copy_pages_mthread function Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-03-08 16:50 +0100

csiph-web