[PATCH 21/26] IB/ocrdma: Improve another size determination in ocrdma_create_srq()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 21/26] IB/ocrdma: Improve another size determination in ocrdma_create_srq()
Date	2017-03-08 15:10 +0100
Message-ID	<tiKrT-7Ca-1@gated-at.bofh.it> (permalink)
References	<tiJct-6C3-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 8 Mar 2017 10:10:50 +0100

Replace the specification of a data type by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index af8798fd35b1..bedc229be89d 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -1915,7 +1915,7 @@ struct ib_srq *ocrdma_create_srq(struct ib_pd *ibpd,
 		if (srq->idx_bit_fields == NULL)
 			goto arm_err;
 		memset(srq->idx_bit_fields, 0xff,
-		       srq->bit_fields_len * sizeof(u32));
+		       srq->bit_fields_len * sizeof(*srq->idx_bit_fields));
 	}
 
 	if (init_attr->attr.srq_limit) {
-- 
2.12.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 21/26] IB/ocrdma: Improve another size determination in  ocrdma_create_srq() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-08 15:10 +0100
  Re: [PATCH 21/26] IB/ocrdma: Improve another size determination in ocrdma_create_srq() Devesh Sharma <devesh.sharma@broadcom.com> - 2017-03-08 16:30 +0100
  Re: [PATCH 21/26] IB/ocrdma: Improve another size determination in  ocrdma_create_srq() Yuval Shaia <yuval.shaia@oracle.com> - 2017-03-09 12:50 +0100

csiph-web