Re: [PATCH 14/26] IB/ocrdma: Improve another size determination in ocrdma_add()

From	Yuval Shaia <yuval.shaia@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 14/26] IB/ocrdma: Improve another size determination in ocrdma_add()
Date	2017-03-08 15:30 +0100
Message-ID	<tiKLf-7L9-1@gated-at.bofh.it> (permalink)
References	<tiJct-6C3-9@gated-at.bofh.it> <tiK8x-7gd-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 08, 2017 at 02:10:33PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 7 Mar 2017 22:12:36 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/infiniband/hw/ocrdma/ocrdma_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c
> index 9caa4c564e34..c49b4491d4e7 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c
> @@ -303,7 +303,7 @@ static struct ocrdma_dev *ocrdma_add(struct be_dev_info *dev_info)
>  	u8 lstate = 0;
>  	struct ocrdma_dev *dev;
>  
> -	dev = (struct ocrdma_dev *)ib_alloc_device(sizeof(struct ocrdma_dev));
> +	dev = (struct ocrdma_dev *)ib_alloc_device(sizeof(*dev));
>  	if (!dev) {
>  		pr_err("Unable to allocate ib device\n");
>  		return NULL;

Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>

> -- 
> 2.12.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 14/26] IB/ocrdma: Improve another size determination in  ocrdma_add() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-08 14:50 +0100
  Re: [PATCH 14/26] IB/ocrdma: Improve another size determination in  ocrdma_add() Yuval Shaia <yuval.shaia@oracle.com> - 2017-03-08 15:30 +0100

csiph-web