Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events

From	Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events
Date	2017-03-08 14:30 +0100
Message-ID	<tiJPd-77d-37@gated-at.bofh.it> (permalink)
References	<tiFsf-3Rn-17@gated-at.bofh.it> <tiFLA-4fF-35@gated-at.bofh.it> <tiGoi-4Ft-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Thanks Masami for the review,

On Wednesday 08 March 2017 03:13 PM, Masami Hiramatsu wrote:
> On Wed,  8 Mar 2017 12:29:08 +0530
> Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
>
>> I don't see any user of this function. This function was being copied
>> to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move
>> print logic into cmd_probe()"). Since then it has became stale.
> Hmm, I have intended to keep it as an library API, which allows 
> user to add event silently (e.g. adding sdt event in background).

Makes sense. Dropping it.

-Ravi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] perf probe: Remove stale func add_perf_probe_events Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-08 10:10 +0100
  Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-08 10:50 +0100
    Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-03-08 14:30 +0100

csiph-web