[PATCH 19/26] IB/ocrdma: Improve another size determination in ocrdma_alloc_mr()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 19/26] IB/ocrdma: Improve another size determination in ocrdma_alloc_mr()
Date	2017-03-08 14:30 +0100
Message-ID	<tiJPc-77d-13@gated-at.bofh.it> (permalink)
References	<tiJct-6C3-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 8 Mar 2017 09:54:42 +0100

Replace the specification of a data type by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index 330617e1ef75..05d55d361cfe 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -3030,7 +3030,7 @@ struct ib_mr *ocrdma_alloc_mr(struct ib_pd *ibpd,
 	if (!mr)
 		return ERR_PTR(-ENOMEM);
 
-	mr->pages = kcalloc(max_num_sg, sizeof(u64), GFP_KERNEL);
+	mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL);
 	if (!mr->pages) {
 		status = -ENOMEM;
 		goto pl_err;
-- 
2.12.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 19/26] IB/ocrdma: Improve another size determination in  ocrdma_alloc_mr() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-08 14:30 +0100
  Re: [PATCH 19/26] IB/ocrdma: Improve another size determination in ocrdma_alloc_mr() Devesh Sharma <devesh.sharma@broadcom.com> - 2017-03-08 16:10 +0100
  Re: [PATCH 19/26] IB/ocrdma: Improve another size determination in  ocrdma_alloc_mr() Yuval Shaia <yuval.shaia@oracle.com> - 2017-03-09 13:10 +0100

csiph-web