Re: [PATCH v5 5/5] perf: powerpc: choose local entry point with kretprobes

From	"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 5/5] perf: powerpc: choose local entry point with kretprobes
Date	2017-03-08 12:50 +0100
Message-ID	<tiIgq-5ZP-23@gated-at.bofh.it> (permalink)
References	<tiF8R-3JU-3@gated-at.bofh.it> <tiF8S-3JU-15@gated-at.bofh.it> <tiHaF-5hD-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017/03/08 11:31AM, Masami Hiramatsu wrote:
> On Wed,  8 Mar 2017 13:56:10 +0530
> "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> 
> > perf now uses an offset from _text/_stext for kretprobes if the kernel
> > supports it, rather than the actual function name. As such, let's choose
> > the LEP for powerpc ABIv2 so as to ensure the probe gets hit. Do it only
> > if the kernel supports specifying offsets with kretprobes.
> 
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> 
> This patch is OK. And I found that most of functions in sym-handling.c
> are used only when libelf is supported. (e.g. probe-event.c itself
> is not built when we have no libelf)
> So, for the next cleanup, this file should not be compiled without
> libelf.

There are still a few functions there which work without libelf. But, I 
agree that the file has far too many #ifdefs between ABIv2 and libelf. I 
will see if I can simplify this file.

Thanks,
Naveen

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 5/5] perf: powerpc: choose local entry point with kretprobes "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-08 09:30 +0100
  Re: [PATCH v5 5/5] perf: powerpc: choose local entry point with  kretprobes Masami Hiramatsu <mhiramat@kernel.org> - 2017-03-08 11:40 +0100
    Re: [PATCH v5 5/5] perf: powerpc: choose local entry point with  kretprobes "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-03-08 12:50 +0100

csiph-web