Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1595111

[PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq()

Show all headers | View raw

Passing "serial" as name during request_irq() results in all serial port
irqs have same name. This does not help much to easily identify which
irq belongs to which serial port instance. Therefore pass dev_name()
during request_irq() so that better identifiable name is listed for
serial ports in cat /proc/interrupts output.

Output of cat /proc/interrupts
Before this patch:
 26:        689          0     GICv2 309 Edge      serial
After this patch:
 26:        696          0     GICv2 309 Edge      2530c00.serial

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/tty/serial/8250/8250_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index 76e03a7de9cc..f83b69f30987 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -218,7 +218,7 @@ static int serial_link_irq_chain(struct uart_8250_port *up)
 		spin_unlock_irq(&i->lock);
 		irq_flags |= up->port.irqflags;
 		ret = request_irq(up->port.irq, serial8250_interrupt,
-				  irq_flags, "serial", i);
+				  irq_flags, dev_name(up->port.dev), i);
 		if (ret < 0)
 			serial_do_unlink(i, up);
 	}
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq() Vignesh R <vigneshr@ti.com> - 2017-03-08 13:30 +0100
  Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during  request_irq() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-08 13:40 +0100
    Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during  request_irq() Vignesh R <vigneshr@ti.com> - 2017-03-09 15:50 +0100
  Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-12 21:10 +0100

csiph-web