Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd

From	Mathias Nyman <mathias.nyman@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
Date	2017-03-08 12:10 +0100
Message-ID	<tiHDI-5Js-19@gated-at.bofh.it> (permalink)
References	<tie8G-1nN-1@gated-at.bofh.it> <tiq9Q-1Dp-7@gated-at.bofh.it> <tiy7n-7dF-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08.03.2017 02:51, Chunfeng Yun wrote:
> On Tue, 2017-03-07 at 17:10 +0200, Mathias Nyman wrote:
>> On 07.03.2017 05:32, Chunfeng Yun wrote:
>>> hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
>>> so checks the Maximum Primary Stream Array Size in the hcc_params
>>> register after adding primary hcd.
>>>
>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>>
>> Thanks.
>> Looks like streams check has never worked for Mediatek xHC hosts,
>>
>> Do you know if this has caused any issues?
>> looks like it should go usb-linus and maybe stable kernels as well.
> No issues on mt8173, because it doesn't support bulk stream. But it
> causes a issue on the newest SoC which is not upstreamed, so I think it
> needn't go stable kernels.
>

Ok, thanks, skipping stable

-Mathias

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-03-07 04:40 +0100
  [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-03-07 04:40 +0100
    Re: [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of  xhci_hcd struct Thierry Reding <treding@nvidia.com> - 2017-03-07 12:10 +0100
      Re: [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of  xhci_hcd struct Mathias Nyman <mathias.nyman@linux.intel.com> - 2017-03-07 16:20 +0100
  Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary  hcd Mathias Nyman <mathias.nyman@linux.intel.com> - 2017-03-07 17:30 +0100
    Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding  primary hcd Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-03-08 02:00 +0100
      Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary  hcd Mathias Nyman <mathias.nyman@linux.intel.com> - 2017-03-08 12:10 +0100

csiph-web