Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment

From	Baoquan He <bhe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment
Date	2017-03-08 11:30 +0100
Message-ID	<tiH10-5e8-23@gated-at.bofh.it> (permalink)
References	<tiEw9-3fU-13@gated-at.bofh.it> <tiEZc-3FD-19@gated-at.bofh.it> <tiFLA-4fF-27@gated-at.bofh.it> <tiG4W-4sw-3@gated-at.bofh.it> <tiGeC-4xJ-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/08/17 at 10:35am, Borislav Petkov wrote:
> On Wed, Mar 08, 2017 at 05:09:55PM +0800, Baoquan He wrote:
> > Yes, it looks better. I can repost with this change. Thanks.
> 
> No it doesn't:

All right, I will just update the code comment. Just back ported kaslr
to our OS product, people reviewed and found the upper boundary of kaslr
mm region is EFI_VA_START, that's not correct, it has to be corrected
firstly in upstream. Then found the confusion in code comment.

Change or keep it, both is fine to me.

Thanks!

> 
> #define EFI_VA_START     ( -4 * (_AC(1, UL) << 30))
> #define EFI_VA_END       (-68 * (_AC(1, UL) << 30))
> 
> That's -4G (the shift by 30) and -68G, respectively.
> 
> > > #define EFI_VA_START    _AC(0xfffffffeffffffff, UL)
> > > #define EFI_VA_END    _AC(0xffffffef00000000, UL)
> 
> That is something which I need to type into a calculator first.
> 
> Can you guys point your attention to something which is really broken
> and stop wasting your time? And there's enough really broken crap left
> and right...
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> Good mailing practices for 400: avoid top-posting and trim the reply.

Thread

[PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Baoquan He <bhe@redhat.com> - 2017-03-08 08:50 +0100
  Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Dave Young <dyoung@redhat.com> - 2017-03-08 09:20 +0100
    Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Baoquan He <bhe@redhat.com> - 2017-03-08 10:10 +0100
    Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Bhupesh Sharma <bhsharma@redhat.com> - 2017-03-08 10:10 +0100
      Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Baoquan He <bhe@redhat.com> - 2017-03-08 10:30 +0100
        Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Borislav Petkov <bp@alien8.de> - 2017-03-08 10:40 +0100
          Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Baoquan He <bhe@redhat.com> - 2017-03-08 11:30 +0100
            Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Borislav Petkov <bp@alien8.de> - 2017-03-08 15:00 +0100
              Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Dave Young <dyoung@redhat.com> - 2017-03-09 02:00 +0100
          Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Bhupesh Sharma <bhsharma@redhat.com> - 2017-03-08 21:10 +0100
      Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Baoquan He <bhe@redhat.com> - 2017-03-08 11:20 +0100
    Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Baoquan He <bhe@redhat.com> - 2017-03-08 10:10 +0100
      Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Borislav Petkov <bp@suse.de> - 2017-03-08 14:10 +0100
      Re: [PATCH 1/2] x86/efi: Correct a tiny mistake in code comment Dave Young <dyoung@redhat.com> - 2017-03-09 02:50 +0100
  [PATCH v2 1/2] x86/efi/64: Clean up code comment about efi region Baoquan He <bhe@redhat.com> - 2017-03-08 14:00 +0100

csiph-web